All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH] mini-os: Fix xenbus initialisation
Date: Thu, 08 Apr 2010 15:39:35 -0700	[thread overview]
Message-ID: <4BBE5B27.6060305@goop.org> (raw)
In-Reply-To: <20100408212505.GG4705@const.famille.thibault.fr>

On 04/08/2010 02:25 PM, Samuel Thibault wrote:
> Jeremy Fitzhardinge, le Thu 08 Apr 2010 12:13:41 -0700, a écrit :
>   
>> Reverting this change (b20f897d6010) makes hvm+stubdom work again.
>>     
> Could you try to revert only parts of them?
>   

I narrowed it down to the first hunk of netfront part of the patch;
applying everything but this works, adding it causes the failure.

    J

diff -r e98537246fe5 extras/mini-os/netfront.c
--- a/extras/mini-os/netfront.c	Thu Apr 08 15:23:00 2010 -0700
+++ b/extras/mini-os/netfront.c	Thu Apr 08 15:23:39 2010 -0700
@@ -407,9 +407,9 @@
     }
 
     snprintf(path, sizeof(path), "%s/state", nodename);
-    err = xenbus_switch_state(xbt, path, XenbusStateConnected);
+    err = xenbus_switch_state(xbt, path, XenbusStateInitialised);
     if (err) {
-        message = "switching state";
+        printk("error writing net initialized: %s\n", err);
         goto abort_transaction;
     }
 

  reply	other threads:[~2010-04-08 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-05 23:27 [PATCH] mini-os: Fix xenbus initialisation Samuel Thibault
2010-04-08 19:13 ` Jeremy Fitzhardinge
2010-04-08 21:25   ` Samuel Thibault
2010-04-08 22:39     ` Jeremy Fitzhardinge [this message]
2010-04-29 20:36       ` Jeremy Fitzhardinge
2010-05-12  0:33         ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBE5B27.6060305@goop.org \
    --to=jeremy@goop.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.