From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] mini-os: Fix xenbus initialisation Date: Thu, 08 Apr 2010 15:39:35 -0700 Message-ID: <4BBE5B27.6060305@goop.org> References: <20100405232748.GK23034@const.famille.thibault.fr> <4BBE2AE5.9050504@goop.org> <20100408212505.GG4705@const.famille.thibault.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20100408212505.GG4705@const.famille.thibault.fr> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Samuel Thibault , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 04/08/2010 02:25 PM, Samuel Thibault wrote: > Jeremy Fitzhardinge, le Thu 08 Apr 2010 12:13:41 -0700, a =E9crit : > =20 >> Reverting this change (b20f897d6010) makes hvm+stubdom work again. >> =20 > Could you try to revert only parts of them? > =20 I narrowed it down to the first hunk of netfront part of the patch; applying everything but this works, adding it causes the failure. J diff -r e98537246fe5 extras/mini-os/netfront.c --- a/extras/mini-os/netfront.c Thu Apr 08 15:23:00 2010 -0700 +++ b/extras/mini-os/netfront.c Thu Apr 08 15:23:39 2010 -0700 @@ -407,9 +407,9 @@ } =20 snprintf(path, sizeof(path), "%s/state", nodename); - err =3D xenbus_switch_state(xbt, path, XenbusStateConnected); + err =3D xenbus_switch_state(xbt, path, XenbusStateInitialised); if (err) { - message =3D "switching state"; + printk("error writing net initialized: %s\n", err); goto abort_transaction; } =20