All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] tcp/mips: Change TCG_AREG0 (fp -> s0)
Date: Fri, 09 Apr 2010 08:42:07 +0200	[thread overview]
Message-ID: <4BBECC3F.7050207@mail.berlios.de> (raw)
In-Reply-To: <20100408224405.GB2220@volta.aurel32.net>

Aurelien Jarno schrieb:
> On Thu, Apr 08, 2010 at 03:38:52PM +0200, Stefan Weil wrote:
>   
>> Register fp is a bad choice for compilations without
>> optimisation, because the compiler makes heavy use
>> of this register (so the resulting code crashes).
>>     
>
> I don't fully understand why the compiler makes use of this register in 
> code where env is declared as register fp.
>   

fp = frame pointer is special. See Paul's answer.

>   
>> Register s0 was used for TCG_AREG1 in earlier releases,
>> but was no longer used and is now free for TCG_AREG0.
>>
>> The resulting code works for compilations without
>> optimisation (tested with qemu mips in qemu mips
>> on x86 host).
>>     
>
> The patch is not complete, at least some changes are missing to 
> tcg_target_callee_save_regs.
>   

Thanks. I'll send an updated patch.

Regards, Stefan

  parent reply	other threads:[~2010-04-09  6:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 13:38 [Qemu-devel] [PATCH] tcp/mips: Change TCG_AREG0 (fp -> s0) Stefan Weil
2010-04-08 22:44 ` [Qemu-devel] " Aurelien Jarno
2010-04-08 23:44   ` Paul Brook
2010-04-09  6:42   ` Stefan Weil [this message]
2010-04-09  7:36     ` [Qemu-devel] " Stefan Weil
2010-04-09 14:45       ` Richard Henderson
2010-04-09 15:28         ` Stefan Weil
2010-04-09 15:57           ` [Qemu-devel] " Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBECC3F.7050207@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.