From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1O0Ebb-0006TD-WB for mharc-grub-devel@gnu.org; Fri, 09 Apr 2010 09:50:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0EbZ-0006RT-WB for grub-devel@gnu.org; Fri, 09 Apr 2010 09:50:42 -0400 Received: from [140.186.70.92] (port=45825 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0EbY-0006PU-0Z for grub-devel@gnu.org; Fri, 09 Apr 2010 09:50:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0EbT-0008Lc-4F for grub-devel@gnu.org; Fri, 09 Apr 2010 09:50:39 -0400 Received: from mail-bw0-f223.google.com ([209.85.218.223]:54555) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0EbS-0008LH-0o for grub-devel@gnu.org; Fri, 09 Apr 2010 09:50:35 -0400 Received: by bwz23 with SMTP id 23so2666189bwz.26 for ; Fri, 09 Apr 2010 06:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=zbp6Z25Z2CmE0NXTLnoJw/V9NkSr5o9Xiw7b8dzNbGg=; b=g043nD1IW0pyEH2vWpJ0GefU5yBn2CZH1YoEcPImPhXEM3ANj96ShzOKZT22afSUFN 3Apewl6GBPnEwIrWvd0U17ABQgsFZoYxynwgVhAOIzed7FRi+Wvji1ZSvJ5qNIbbJUL3 a+H6N+8ltzXGSvDYlfMtYsN+1TVHAl9ptxm7M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=qM0chPohVw2G87sO4eSYhbk1LvABCXj032arMvmOgC1CfUHCymfReH3dYxP0bNLrvg uabroPj7vu7tgyviBkXh3hWLrl8pKdbO4f0pdajoWX/rciD576bdvO/mBXJzInetCcI1 F3G7PDPnmQxrpiFFFbVZYkhZQDatBbkmlTSd0= Received: by 10.204.27.14 with SMTP id g14mr134901bkc.36.1270821032595; Fri, 09 Apr 2010 06:50:32 -0700 (PDT) Received: from debian.bg45.phnet (125-149.203-62.cust.bluewin.ch [62.203.149.125]) by mx.google.com with ESMTPS id 15sm534619bwz.12.2010.04.09.06.50.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Apr 2010 06:50:31 -0700 (PDT) Message-ID: <4BBF30A0.1040206@gmail.com> Date: Fri, 09 Apr 2010 15:50:24 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigA662FFDA86D8E11D86F84F1E" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Testcase for checking lvm module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2010 13:50:42 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA662FFDA86D8E11D86F84F1E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable BVK Chaitanya wrote: > Attached! > > > =20 +size=3D128M +disk1=3D`mktemp` +disk2=3D`mktemp` Plain mktemp will fail on FreeBSD. Idk for well freebsd supports linux lv= m though +lvm=3D/sbin/lvmn +parted=3D/sbin/parted +losetup=3D/sbin/losetup You don't check for real existence of these files. And letting use $PATH = is better IMO than hardcoding path to executables +if test `id -u` !=3D "0"; then + exit 0 +fi + There should be a warning here > =20 > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigA662FFDA86D8E11D86F84F1E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAku/MKYACgkQNak7dOguQgkc/AD+Jmh+Xq+OvY2pnbVVYxj/b/Tq Ajxt4/GUQ3p4dCJ0apsA/j4k98Ozjhqj+/UlGXLCuXeJCqe0BEVo5rKKVhM7QBaJ =LLxa -----END PGP SIGNATURE----- --------------enigA662FFDA86D8E11D86F84F1E--