From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: grub themes fail to load due to missing dependencies
Date: Fri, 09 Apr 2010 16:38:13 +0200 [thread overview]
Message-ID: <4BBF3BD5.8050609@gmail.com> (raw)
In-Reply-To: <c2106971003180106q40740c7bu1c8e2aacadf814d8@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
Mario Vazquez wrote:
> Grub 1.98 comes with the gfxmenu patch. The code used to include the
> entries in 00_header currently only adds the theme name, but nothing
> else. Due to either a bug or feature, currently grub do not load
> dependencies automatically. This means that when using a theme, it
> will not load the image modules or fonts required by the selected
> theme, causing it to fail to load at all.
>
>
Good idea but the implementation has problems like e.g: it may load the
same module twice in a setup like:
a.png
b.jpg
c.png
I've made my patch based on your idea and I'm currently testing and
comitting it.
> I included a patch that searches the theme directory, and add the
> entries just before the theme file.
>
> How to reproduce:
> 1. Put a GRUB_THEME entry with your theme in /etc/default/grub.
> 2. Generate your grub.cfg with grub-mkconfig
> 3. Reboot
> 4. The theme will not load at all.
>
> The patch was tested against both grub 1.98 and trunk r2263
> https://savannah.gnu.org/bugs/?29251
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
next prev parent reply other threads:[~2010-04-09 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 8:06 grub themes fail to load due to missing dependencies Mario Vazquez
2010-04-09 14:38 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-18 16:54 Mario Vazquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBF3BD5.8050609@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.