Re: [Qemu-devel] [PATCH] Fix cross compilation

[Stefan Weil <weil@mail.berlios.de>]

Aurelien Jarno schrieb:
> On Sun, Mar 28, 2010 at 11:44:05AM +0200, Stefan Weil wrote:
>> This patch enhances the algorithm which finds the correct settings
>> for SDL.
>> For cross compilations (when cross_prefix is set), it looks for
>> sdl-config
>> with cross prefix. Here is the complete search order:
>>
>> ${cross_prefix}sdl_config (new, only used for cross compilation)
>> $(cross_prefix}pkg-config (old)
>> pkg-config (old, needs PATH)
>> sdl-config (old, needs PATH)
>
> Why a different order for cross-compilation than for native
> compilation? I would expect the same order in both case, that is
> pkg-config first, and then sdl_config. The general rule, not specific to
> QEMU, is to prefer pkg-config over *config programs.
>

Maybe the correct solution should be

$(cross_prefix}pkg-config (old)
${cross_prefix}sdl_config (new, only used for cross compilation)

Fallback to native *-config and "hope for the best"
is no good solution for cross compilations.

If nobody disagrees, I'll send a patch without this fallback.

Stefan