From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383Ab0DJMgv (ORCPT ); Sat, 10 Apr 2010 08:36:51 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.161]:24266 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060Ab0DJMgt (ORCPT ); Sat, 10 Apr 2010 08:36:49 -0400 X-RZG-AUTH: :P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrT1q0ngWNsKR9Dbc7nsXJ75k/Dr7GSgWf1 X-RZG-CLASS-ID: mo00 Message-ID: <4BC070E0.6070601@hartkopp.net> Date: Sat, 10 Apr 2010 14:36:48 +0200 From: Oliver Hartkopp User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090706) MIME-Version: 1.0 To: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= , Eric Dumazet CC: Oliver Hartkopp , Urs Thuermann , socketcan-core@lists.berlios.de, Network Development , LKML Subject: Re: Linux 2.6.34-rc3 + CAN build problem References: <4BC03340.5020500@freemail.hu> <1270892851.2093.32.camel@edumazet-laptop> <4BC054AE.7040303@freemail.hu> In-Reply-To: <4BC054AE.7040303@freemail.hu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Németh Márton wrote: > Eric Dumazet írta: >> Le samedi 10 avril 2010 à 10:13 +0200, Németh Márton a écrit : >>> Hi, >>> >>> I have some problem building Liunux kernel 2.6.34-rc3 with the attached .config: >>> >>> $ make clean bzImage modules >>> [...] >>> CC net/socket.o >>> LD net/802/built-in.o >>> LD net/can/built-in.o >>> CC [M] net/can/bcm.o >>> CC [M] net/can/raw.o >>> In file included from /mnt/store/nmarci/src/linux-2.6.34-rc3/arch/x86/include/asm/uaccess.h:571, >>> from include/net/checksum.h:25, >>> from include/linux/skbuff.h:28, >>> from include/linux/if_ether.h:124, >>> from include/linux/netdevice.h:29, >>> from net/can/raw.c:48: >>> In function ‘copy_from_user’, >>> inlined from ‘raw_setsockopt’ at net/can/raw.c:447: >>> /mnt/store/nmarci/src/linux-2.6.34-rc3/arch/x86/include/asm/uaccess_32.h:212: error: call to ‘copy_from_user_overflow’ declared with attribute error: >>> copy_from_user() buffer size is not provably correct >>> make[2]: *** [net/can/raw.o] Error 1 >>> make[1]: *** [net/can] Error 2 >>> make: *** [net] Error 2 >>> >>> >> Could you give us your compiler version ? > > $ gcc --version > gcc (Debian 4.4.2-9) 4.4.3 20100108 (prerelease) > Copyright (C) 2009 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > >> Code is fine, but compiler a bit dumb :( >> >> [PATCH] can: avoids a false warning >> >> At this point optlen == sizeof(sfilter) but some compilers are dumb. >> >> Reported-by: Németh Márton > Signed-off-by: Eric Dumazet Acked-by: Oliver Hartkopp Btw. i'm using the same compiler here (Debian Squeeze), and i did not have any build problems with 2.6.24-rc3 and the following kernels like the currently running 2.6.34-rc3-00288-gab195c5: $ cat /proc/version Linux version 2.6.34-rc3-00288-gab195c5 (hartko@vwagwolkf320) (gcc version 4.4.3 20100108 (prerelease) (Debian 4.4.2-9) ) #70 SMP Tue Apr 6 19:14:52 CEST 2010 So i wonder why Nemeth trapped into this problem ... probably an include file mix-up? Regards, Oliver >> --- >> diff --git a/net/can/raw.c b/net/can/raw.c >> index 3a7dffb..da99cf1 100644 >> --- a/net/can/raw.c >> +++ b/net/can/raw.c >> @@ -445,7 +445,7 @@ static int raw_setsockopt(struct socket *sock, int level, int optname, >> return -EFAULT; >> } >> } else if (count == 1) { >> - if (copy_from_user(&sfilter, optval, optlen)) >> + if (copy_from_user(&sfilter, optval, sizeof(sfilter))) >> return -EFAULT; >> } >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: Linux 2.6.34-rc3 + CAN build problem Date: Sat, 10 Apr 2010 14:36:48 +0200 Message-ID: <4BC070E0.6070601@hartkopp.net> References: <4BC03340.5020500@freemail.hu> <1270892851.2093.32.camel@edumazet-laptop> <4BC054AE.7040303@freemail.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Network Development , Oliver Hartkopp , LKML , Urs Thuermann To: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= , Eric Dumazet Return-path: In-Reply-To: <4BC054AE.7040303-Y8qEzhMunLyT9ig0jae3mg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org TsOpbWV0aCBNw6FydG9uIHdyb3RlOgo+IEVyaWMgRHVtYXpldCDDrXJ0YToKPj4gTGUgc2FtZWRp IDEwIGF2cmlsIDIwMTAgw6AgMTA6MTMgKzAyMDAsIE7DqW1ldGggTcOhcnRvbiBhIMOpY3JpdCA6 Cj4+PiBIaSwKPj4+Cj4+PiBJIGhhdmUgc29tZSBwcm9ibGVtIGJ1aWxkaW5nIExpdW51eCBrZXJu ZWwgMi42LjM0LXJjMyB3aXRoIHRoZSBhdHRhY2hlZCAuY29uZmlnOgo+Pj4KPj4+ICQgbWFrZSBj bGVhbiBiekltYWdlIG1vZHVsZXMKPj4+IFsuLi5dCj4+PiAgIENDICAgICAgbmV0L3NvY2tldC5v Cj4+PiAgIExEICAgICAgbmV0LzgwMi9idWlsdC1pbi5vCj4+PiAgIExEICAgICAgbmV0L2Nhbi9i dWlsdC1pbi5vCj4+PiAgIENDIFtNXSAgbmV0L2Nhbi9iY20ubwo+Pj4gICBDQyBbTV0gIG5ldC9j YW4vcmF3Lm8KPj4+IEluIGZpbGUgaW5jbHVkZWQgZnJvbSAvbW50L3N0b3JlL25tYXJjaS9zcmMv bGludXgtMi42LjM0LXJjMy9hcmNoL3g4Ni9pbmNsdWRlL2FzbS91YWNjZXNzLmg6NTcxLAo+Pj4g ICAgICAgICAgICAgICAgICBmcm9tIGluY2x1ZGUvbmV0L2NoZWNrc3VtLmg6MjUsCj4+PiAgICAg ICAgICAgICAgICAgIGZyb20gaW5jbHVkZS9saW51eC9za2J1ZmYuaDoyOCwKPj4+ICAgICAgICAg ICAgICAgICAgZnJvbSBpbmNsdWRlL2xpbnV4L2lmX2V0aGVyLmg6MTI0LAo+Pj4gICAgICAgICAg ICAgICAgICBmcm9tIGluY2x1ZGUvbGludXgvbmV0ZGV2aWNlLmg6MjksCj4+PiAgICAgICAgICAg ICAgICAgIGZyb20gbmV0L2Nhbi9yYXcuYzo0ODoKPj4+IEluIGZ1bmN0aW9uIOKAmGNvcHlfZnJv bV91c2Vy4oCZLAo+Pj4gICAgIGlubGluZWQgZnJvbSDigJhyYXdfc2V0c29ja29wdOKAmSBhdCBu ZXQvY2FuL3Jhdy5jOjQ0NzoKPj4+IC9tbnQvc3RvcmUvbm1hcmNpL3NyYy9saW51eC0yLjYuMzQt cmMzL2FyY2gveDg2L2luY2x1ZGUvYXNtL3VhY2Nlc3NfMzIuaDoyMTI6IGVycm9yOiBjYWxsIHRv IOKAmGNvcHlfZnJvbV91c2VyX292ZXJmbG934oCZIGRlY2xhcmVkIHdpdGggYXR0cmlidXRlIGVy cm9yOgo+Pj4gY29weV9mcm9tX3VzZXIoKSBidWZmZXIgc2l6ZSBpcyBub3QgcHJvdmFibHkgY29y cmVjdAo+Pj4gbWFrZVsyXTogKioqIFtuZXQvY2FuL3Jhdy5vXSBFcnJvciAxCj4+PiBtYWtlWzFd OiAqKiogW25ldC9jYW5dIEVycm9yIDIKPj4+IG1ha2U6ICoqKiBbbmV0XSBFcnJvciAyCj4+Pgo+ Pj4KPj4gQ291bGQgeW91IGdpdmUgdXMgeW91ciBjb21waWxlciB2ZXJzaW9uID8KPiAKPiAkIGdj YyAtLXZlcnNpb24KPiBnY2MgKERlYmlhbiA0LjQuMi05KSA0LjQuMyAyMDEwMDEwOCAocHJlcmVs ZWFzZSkKPiBDb3B5cmlnaHQgKEMpIDIwMDkgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMu Cj4gVGhpcyBpcyBmcmVlIHNvZnR3YXJlOyBzZWUgdGhlIHNvdXJjZSBmb3IgY29weWluZyBjb25k aXRpb25zLiAgVGhlcmUgaXMgTk8KPiB3YXJyYW50eTsgbm90IGV2ZW4gZm9yIE1FUkNIQU5UQUJJ TElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4KPiAKPj4gQ29kZSBpcyBm aW5lLCBidXQgY29tcGlsZXIgYSBiaXQgZHVtYiA6KAo+Pgo+PiBbUEFUQ0hdIGNhbjogYXZvaWRz IGEgZmFsc2Ugd2FybmluZwo+Pgo+PiBBdCB0aGlzIHBvaW50IG9wdGxlbiA9PSBzaXplb2Yoc2Zp bHRlcikgYnV0IHNvbWUgY29tcGlsZXJzIGFyZSBkdW1iLgo+Pgo+PiBSZXBvcnRlZC1ieTogTsOp bWV0aCBNw6FydG9uIDxubTEyN0BmcmVlbWFpbC5oCj4+IFNpZ25lZC1vZmYtYnk6IEVyaWMgRHVt YXpldCA8ZXJpYy5kdW1hemV0QGdtYWlsLmNvbT4KCkFja2VkLWJ5OiBPbGl2ZXIgSGFydGtvcHAg PG9saXZlckBoYXJ0a29wcC5uZXQ+CgpCdHcuIGknbSB1c2luZyB0aGUgc2FtZSBjb21waWxlciBo ZXJlIChEZWJpYW4gU3F1ZWV6ZSksIGFuZCBpIGRpZCBub3QgaGF2ZSBhbnkKYnVpbGQgcHJvYmxl bXMgd2l0aCAyLjYuMjQtcmMzIGFuZCB0aGUgZm9sbG93aW5nIGtlcm5lbHMgbGlrZSB0aGUgY3Vy cmVudGx5CnJ1bm5pbmcgMi42LjM0LXJjMy0wMDI4OC1nYWIxOTVjNToKCiQgY2F0IC9wcm9jL3Zl cnNpb24KTGludXggdmVyc2lvbiAyLjYuMzQtcmMzLTAwMjg4LWdhYjE5NWM1IChoYXJ0a29Adndh Z3dvbGtmMzIwKSAoZ2NjIHZlcnNpb24KNC40LjMgMjAxMDAxMDggKHByZXJlbGVhc2UpIChEZWJp YW4gNC40LjItOSkgKSAjNzAgU01QIFR1ZSBBcHIgNiAxOToxNDo1MiBDRVNUCjIwMTAKClNvIGkg d29uZGVyIHdoeSBOZW1ldGggdHJhcHBlZCBpbnRvIHRoaXMgcHJvYmxlbSAuLi4gcHJvYmFibHkg YW4gaW5jbHVkZSBmaWxlCm1peC11cD8KClJlZ2FyZHMsCk9saXZlcgoKCj4+IC0tLQo+PiBkaWZm IC0tZ2l0IGEvbmV0L2Nhbi9yYXcuYyBiL25ldC9jYW4vcmF3LmMKPj4gaW5kZXggM2E3ZGZmYi4u ZGE5OWNmMSAxMDA2NDQKPj4gLS0tIGEvbmV0L2Nhbi9yYXcuYwo+PiArKysgYi9uZXQvY2FuL3Jh dy5jCj4+IEBAIC00NDUsNyArNDQ1LDcgQEAgc3RhdGljIGludCByYXdfc2V0c29ja29wdChzdHJ1 Y3Qgc29ja2V0ICpzb2NrLCBpbnQgbGV2ZWwsIGludCBvcHRuYW1lLAo+PiAgCQkJCXJldHVybiAt RUZBVUxUOwo+PiAgCQkJfQo+PiAgCQl9IGVsc2UgaWYgKGNvdW50ID09IDEpIHsKPj4gLQkJCWlm IChjb3B5X2Zyb21fdXNlcigmc2ZpbHRlciwgb3B0dmFsLCBvcHRsZW4pKQo+PiArCQkJaWYgKGNv cHlfZnJvbV91c2VyKCZzZmlsdGVyLCBvcHR2YWwsIHNpemVvZihzZmlsdGVyKSkpCj4+ICAJCQkJ cmV0dXJuIC1FRkFVTFQ7Cj4+ICAJCX0KPj4gIApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpTb2NrZXRjYW4tY29yZSBtYWlsaW5nIGxpc3QKU29ja2V0Y2Fu LWNvcmVAbGlzdHMuYmVybGlvcy5kZQpodHRwczovL2xpc3RzLmJlcmxpb3MuZGUvbWFpbG1hbi9s aXN0aW5mby9zb2NrZXRjYW4tY29yZQo=