From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0cP2-0006NQ-N6 for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:20 -0400 Received: from [140.186.70.92] (port=50368 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0cP0-0006NG-PT for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0cOz-0005hG-Eh for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:18 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:59604) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0cOz-0005gq-1l for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:17 -0400 Message-ID: <4BC095F8.6090606@mail.berlios.de> Date: Sat, 10 Apr 2010 17:15:04 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix cross compilation References: <1269769445-7350-1-git-send-email-weil@mail.berlios.de> <20100409194401.GE21042@volta.aurel32.net> <4BC02A07.8080307@mail.berlios.de> <20100410150607.GD23683@volta.aurel32.net> In-Reply-To: <20100410150607.GD23683@volta.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: QEMU Developers Aurelien Jarno schrieb: > On Sat, Apr 10, 2010 at 09:34:31AM +0200, Stefan Weil wrote: >> Aurelien Jarno schrieb: >>> On Sun, Mar 28, 2010 at 11:44:05AM +0200, Stefan Weil wrote: >>>> This patch enhances the algorithm which finds the correct settings >>>> for SDL. >>>> For cross compilations (when cross_prefix is set), it looks for >>>> sdl-config >>>> with cross prefix. Here is the complete search order: >>>> >>>> ${cross_prefix}sdl_config (new, only used for cross compilation) >>>> $(cross_prefix}pkg-config (old) >>>> pkg-config (old, needs PATH) >>>> sdl-config (old, needs PATH) >>> Why a different order for cross-compilation than for native >>> compilation? I would expect the same order in both case, that is >>> pkg-config first, and then sdl_config. The general rule, not specific to >>> QEMU, is to prefer pkg-config over *config programs. >>> >> Maybe the correct solution should be >> >> $(cross_prefix}pkg-config (old) >> ${cross_prefix}sdl_config (new, only used for cross compilation) > > Why sdl_config only for cross compilation? If $(cross_prefix} is not set > for native compilation, always looking for: > > - first to $(cross_prefix}pkg-config > - and then to ${cross_prefix}sdl-config > > looks the way to go. D'accord. That's what I wanted to say. The "only used for cross compilation" was too much copy + paste.