All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Avi Kivity <avi@redhat.com>
Cc: KVM General <kvm@vger.kernel.org>
Subject: Re: Problem with KVM guest switching to x86 long mode
Date: Sun, 11 Apr 2010 13:02:10 +0300	[thread overview]
Message-ID: <4BC19E22.7050602@cs.helsinki.fi> (raw)
In-Reply-To: <4BC19D71.2060703@redhat.com>

Avi Kivity wrote:
> On 04/11/2010 12:48 PM, Pekka Enberg wrote:
>>> So the guest is in long mode, happily trying to access pci config space.
>>>
>>> MAXPHYADDR comes from cpuid 80000008.eax[0:7].  Typical values are 
>>> 36-40 (number of physical address bits supported by the processor).  
>>> What value does your guest see?
>>
>>
>> Ah, nice catch! The host cpuid doesn't seem to support 80000008 at so 
>> I didn't set it up in the guest either. I now added dummy emulation 
>> for it and the triple fault is fixed.
> 
> It should work without 80000008 set up - failure should happen only if 
> it is setup incorrectly:
> 
> int cpuid_maxphyaddr(struct kvm_vcpu *vcpu)
> {
>     struct kvm_cpuid_entry2 *best;
> 
>     best = kvm_find_cpuid_entry(vcpu, 0x80000008, 0);
>     if (best)
>         return best->eax & 0xff;
>     return 36;
> }

Well, like I said, if I don't add an entry for it in struct kvm_cpuid2 
that's passed to KVM_SET_CPUID2 ioctl, I see a triple fault on Core 2 
Duo CPU that doesn't seem to have native 0x80000008.

			Pekka

  reply	other threads:[~2010-04-11 10:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 18:26 Problem with KVM guest switching to x86 long mode Pekka Enberg
2010-04-08 18:36 ` Avi Kivity
2010-04-08 18:59   ` Pekka Enberg
2010-04-08 19:30     ` Avi Kivity
2010-04-11  6:30       ` Pekka Enberg
2010-04-11  9:16         ` Avi Kivity
2010-04-11  9:48           ` Pekka Enberg
2010-04-11  9:59             ` Avi Kivity
2010-04-11 10:02               ` Pekka Enberg [this message]
2010-04-11 11:48                 ` Avi Kivity
2010-04-11 11:52                   ` Pekka Enberg
2010-04-11 12:02                     ` Avi Kivity
2010-04-11 12:04                       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC19E22.7050602@cs.helsinki.fi \
    --to=penberg@cs.helsinki.fi \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.