From: Avi Kivity <avi@redhat.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Fix MAXPHYADDR calculation when cpuid does not support it
Date: Sun, 11 Apr 2010 16:48:41 +0300 [thread overview]
Message-ID: <4BC1D339.20704@redhat.com> (raw)
In-Reply-To: <4BC1D26E.9080706@cs.helsinki.fi>
On 04/11/2010 04:45 PM, Pekka Enberg wrote:
> Pekka Enberg wrote:
>> Avi Kivity wrote:
>>>> Hmm, doesn't seem to work here. I still that triple fault in guest.
>>>
>>> Can you add a printk to see what value is returned and why?
>>
>> Argh, it's a off-by one bug in my userspace tool... So the CPU really
>> does support 0x80000008 and I'm just an idiot. :-)
>
> So to explain this a bit more: I'm setting 0x80000000 to 0x80000008
> but failing to install an entry for 0x80000008. I don't quite
> understand why kvm_find_cpuid_entry() doesn't return NULL in this case?
cpuid is defined to return the highest entry if it doesn't find a match.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-04-11 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-11 12:33 [PATCH] KVM: Fix MAXPHYADDR calculation when cpuid does not support it Avi Kivity
2010-04-11 12:35 ` Avi Kivity
2010-04-11 13:32 ` Pekka Enberg
2010-04-11 13:33 ` Avi Kivity
2010-04-11 13:35 ` Pekka Enberg
2010-04-11 13:45 ` Pekka Enberg
2010-04-11 13:48 ` Avi Kivity [this message]
2010-04-11 13:53 ` Pekka Enberg
2010-04-11 13:55 ` Avi Kivity
2010-04-11 13:59 ` Pekka Enberg
2010-04-12 16:37 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC1D339.20704@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.