From: Michael Barkowski <michaelbarkowski@ruggedcom.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: "David S. Miller" <davem@davemloft.net>,
Julia Lawall <julia@diku.dk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: hdlc_ppp: why no detach()?
Date: Mon, 12 Apr 2010 10:15:28 -0400 [thread overview]
Message-ID: <4BC32B00.1030600@ruggedcom.com> (raw)
Hello Krzyztof,
I am looking at your hdlc_ppp code and I don't understand: why is there
not the equivalent of fr_detach() in there?
pc8300_drv:cpc_remove_one() frees netdevs quite confidently but I wonder
how it can be so sure that there are not skbs in hdlc_ppp's tx_queue
associated with those devices before freeing them....
Even if you wanted to switch a device from PPP to Frame Relay, I don't
see the method right now. If I may ask, please, what am I missing?
If you agree there is a need for detach(), I would be happy to work on
it and make a submission.
thanks for your time,
--
Michael Barkowski
RuggedCom, Inc.
next reply other threads:[~2010-04-12 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 14:15 Michael Barkowski [this message]
2010-04-12 14:34 ` hdlc_ppp: why no detach()? Michael Barkowski
2010-04-14 22:48 ` Krzysztof Halasa
2010-04-15 0:02 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC32B00.1030600@ruggedcom.com \
--to=michaelbarkowski@ruggedcom.com \
--cc=davem@davemloft.net \
--cc=julia@diku.dk \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.