From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch 1/3] CLD: End-to-end verbosity v3 Date: Wed, 14 Apr 2010 00:01:23 -0400 Message-ID: <4BC53E13.3050801@garzik.org> References: <20100413143037.55455efe@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Vy38C8/+VjNEkv/rZJ99PCcOEP/Ps+6avIHDmOX+aHE=; b=k9U4aqpagrVXUogtlM7U9yh2vGoH80oC0YvnH3ScaXxMhZZDyiuNa1cQTqwkMeYpcx NVxv83IDEooJ4vuS0nGo9I2+4s3DOAA/DJu7PXhdMMBEQtgZFzoCu1V9tcN2R9RsiqhX cYIBfeQvibZAUVZAhD4pw7ROhH5i0WyGbNl2M= In-Reply-To: <20100413143037.55455efe@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 04/13/2010 04:30 PM, Pete Zaitcev wrote: > It has been observed that it's not possible to enable the session-level > verbose dump with -v switch of cldcli anymore (post XDR and ncld). > > The main issue is that it is impossible to set the session verbosity by > an application control. Secondary issue is that if application attempts > to change the verbosity level, it cannot do so for newly-created sessions, > because the session structure is allocated when session is created. > > Contributing to the confusion is the desire not to enable excessive > verbosity in the CLD sessions whenever debugging is requested. > > To fix these issues, the patch does the following: > > - Drops all commented-out inserts that assign additional verbosity > from libraries. Permits top-level applications to specify verbosity > (what cldcli -v was intended to do). > > - Splits per-packet verbosity away from debugging messages. > > - Establishes -D 2 to mean "CLD protocol verbosity" across applications > and the daemon (this replaces the "old" -v). The existing -D 1 now > controls the program debugging only, and there is no bit mask. > > Coincidentially this fixes the crash whenever there's a resolution > failure for an SRV record. > > Signed-Off-By: Pete Zaitcev > > --- > include/cldc.h | 1 > include/hail_log.h | 24 +++++---- > include/ncld.h | 2 > lib/cldc.c | 104 ++++++++++++++++++++++++----------------- > pkg/cld.sysconf | 2 > server/server.c | 19 ++++--- > test/basic-io.c | 4 - > test/basic-session.c | 2 > test/lock-file.c | 2 > tools/cldcli.c | 17 +++--- > tools/cldfuse.c | 2 > 11 files changed, 104 insertions(+), 75 deletions(-) applied, thanks for the revisions Long term, I think the per-packet session logging macro should be made more clear, perhaps calling it HAIL_SESS or even HAIL_PKT Jeff