From: Cong Wang <amwang@redhat.com>
To: penguin-kernel@i-love.sakura.ne.jp
Cc: rolandd@cisco.com, sean.hefty@intel.com, opurdila@ixiacom.com,
eric.dumazet@gmail.com, netdev@vger.kernel.org,
nhorman@tuxdriver.com, davem@davemloft.net,
ebiederm@xmission.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Infiniband: Randomize local port allocation.
Date: Wed, 14 Apr 2010 12:38:39 +0800 [thread overview]
Message-ID: <4BC546CF.9020004@redhat.com> (raw)
In-Reply-To: <201004140201.o3E21Aqn075978@www262.sakura.ne.jp>
penguin-kernel@i-love.sakura.ne.jp wrote:
> Sean Hefty wrote:
>> Sean and Roland, is below patch correct?
>>> inet_is_reserved_local_port() is the new function proposed in this patchset.
>> It looks correct to me. I didn't test the patch series, but if I comment out
>> the call to inet_is_reserved_local_port() in the provided below, the changes
>> worked fine for me.
>>
>> Acked-by: Sean Hefty <sean.hefty@intel.com>
>>
> Thank you for testing.
>
> I think it is better to split this patch into
>
> Part 1: Make cma_alloc_any_port() to use cma_alloc_port().
>
> Part 2: Insert "!inet_is_reserved_local_port(rover) &&" line.
>
> for future "git bisect".
>
Right, thanks a lot for your work!
So, I will rebase my patch 3/3 on top of this patch. I hope someone
could take this one asap.
next prev parent reply other threads:[~2010-04-14 4:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 10:03 [Patch v8 0/3] net: reserve ports for applications using fixed port numbers Amerigo Wang
2010-04-12 10:04 ` [Patch 1/3] sysctl: refactor integer handling proc code Amerigo Wang
2010-04-12 10:18 ` Alexey Dobriyan
2010-04-13 11:18 ` Alexey Dobriyan
2010-04-13 7:35 ` Cong Wang
2010-04-12 10:18 ` Alexey Dobriyan
2010-04-12 10:04 ` [Patch 2/3] sysctl: add proc_do_large_bitmap Amerigo Wang
2010-04-12 10:04 ` [Patch 3/3] net: reserve ports for applications using fixed port numbers Amerigo Wang
2010-04-13 1:21 ` Tetsuo Handa
2010-04-13 7:13 ` Cong Wang
2010-04-13 8:48 ` Cong Wang
2010-04-13 13:07 ` Tetsuo Handa
2010-04-13 16:32 ` Sean Hefty
2010-04-14 2:01 ` [PATCH] Infiniband: Randomize local port allocation penguin-kernel
2010-04-14 4:38 ` Cong Wang [this message]
2010-04-15 0:01 ` Sean Hefty
2010-04-15 2:29 ` Tetsuo Handa
[not found] ` <201004150229.o3F2T4dZ054768-etx+eQDEXHD7nzcFbJAaVXf5DAMn2ifp@public.gmane.org>
2010-04-15 19:55 ` [PATCH] rdma/cm: " Sean Hefty
2010-04-15 19:55 ` Sean Hefty
2010-04-15 19:55 ` Sean Hefty
2010-04-16 2:22 ` Cong Wang
[not found] ` <4BC7C9CF.20403-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-04-16 13:54 ` Tetsuo Handa
2010-04-16 13:54 ` Tetsuo Handa
[not found] ` <201004162254.FJF73478.SHOOMOFtQFVJLF-JPay3/Yim36HaxMnTkn67Xf5DAMn2ifp@public.gmane.org>
2010-04-16 20:30 ` David Miller
2010-04-16 20:30 ` David Miller
2010-04-20 4:34 ` Cong Wang
2010-04-21 23:19 ` [PATCH] Infiniband: " Roland Dreier
2010-04-21 23:22 ` Roland Dreier
2010-04-15 5:46 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC546CF.9020004@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=opurdila@ixiacom.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rolandd@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.