From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com>
To: ext Herbert Xu <herbert@gondor.hengli.com.au>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCHv3 2/2] crypto: omap-sham - omap sha1 & md5 driver
Date: Wed, 14 Apr 2010 09:41:28 +0300 [thread overview]
Message-ID: <4BC56398.40500@nokia.com> (raw)
In-Reply-To: <20100414062052.GA20395@gondor.apana.org.au>
On 14/04/10 09:20, ext Herbert Xu wrote:
> Dmitry Kasatkin<dmitry.kasatkin@nokia.com> wrote:
>
>> Earlier kernel contained omap sha1 and md5 driver, which was not maintained,
>> was not ported to new crypto APIs and removed from the source tree.
>>
>> - implements async and sync crypto API using dma and cpu.
>> - supports multiple sham instances if available
>>
>> Signed-off-by: Dmitry Kasatkin<dmitry.kasatkin@nokia.com>
>>
> You have not addressed my objections raised earlier.
>
> Also, why are you exporting a shash object? You cannot sleep during
> shash operations (except for setkey).
>
>
what do you mean "exporting shash object"?
Providing shash alg?
I was not sure if it is needed if ahash is available.
Should I remove shash alg at all?
> Cheers,
>
next prev parent reply other threads:[~2010-04-14 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 8:08 [PATCHv3 0/2] omap-sham: OMAP SHA1/MD5 driver Dmitry Kasatkin
2010-04-13 8:08 ` [PATCHv3 1/2] crypto: updates omap sham device related platform code Dmitry Kasatkin
2010-04-13 8:08 ` [PATCHv3 2/2] crypto: omap-sham - omap sha1 & md5 driver Dmitry Kasatkin
2010-04-14 6:20 ` Herbert Xu
2010-04-14 6:38 ` Dmitry Kasatkin
2010-04-14 6:41 ` Dmitry Kasatkin [this message]
2010-04-14 6:45 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC56398.40500@nokia.com \
--to=dmitry.kasatkin@nokia.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.