Re: [Patch] continue_hypercall_on_cpu rework using tasklets

[Juergen Gross <juergen.gross@ts.fujitsu.com>]

Keir Fraser wrote:
> On 14/04/2010 05:26, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:
> 
>>> Why do you change the interface of continue_hypercall_on_cpu()? What's a
>>> 'hdl' anyway?
>> I need a way to find the migrate_info structure in case of nested calls of
>> continue_hypercall_on_cpu(). Originally this was done by storing it in the
>> vcpu structure, but this can't be done any more using tasklets. In my first
>> attempt I saved it in the per-cpu area, but this approach isn't working if
>> continue_hypercall_on_cpu() is called concurrently. So the cleanest way is
>> to pass it via a parameter.
> 
> The per-cpu area method should work fine, since Xen is non-preemptive? I
> don't think the concurrency you are concerned about can happen.

The tasklet knows only on which cpu it is running, so the data has to be
stored on the target cpu. And one pcpu can be the target of concurrent calls
from different calling cpus...


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html