Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : Fix historic msleep wrapping

[Jan Kiszka <jan.kiszka@domain.hid>]

Gilles Chanteperdrix wrote:
> GIT version control wrote:
>> Module: xenomai-jki
>> Branch: queues/proc
>> Commit: f14c48e888b7f811f4c040b3b7ff0783fe115978
>> URL:    http://git.xenomai.org/?p=xenomai-jki.git;a=commit;h=f14c48e888b7f811f4c040b3b7ff0783fe115978
>>
>> Author: Jan Kiszka <jan.kiszka@domain.hid>
>> Date:   Mon Apr  5 17:25:29 2010 +0200
>>
>> Fix historic msleep wrapping
>>
>> Probably only an academic exercise: Fix the rounding bug in msleep
>> wrapper for kernels < 2.4.28.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@domain.hid>
>>
>> ---
>>
>>  include/asm-generic/wrappers.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/asm-generic/wrappers.h b/include/asm-generic/wrappers.h
>> index 15d9837..64ec43f 100644
>> --- a/include/asm-generic/wrappers.h
>> +++ b/include/asm-generic/wrappers.h
>> @@ -197,7 +197,7 @@ do {									\
>>  #if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,28)
>>  #define msleep(x) do {				 \
>>  	set_current_state(TASK_UNINTERRUPTIBLE); \
>> -	schedule_timeout((x)*(HZ/1000));         \
>> +	schedule_timeout(((x)*HZ)/1000);         \
>>  } while(0)
>>  #endif
> 
> Mmm... changing that code again? What about replacing it with the close
> patch we discussed?

The close patch (actually a rewrite of it) will only avoid polling on
the context reference count. Other polling is part of the RTDM API and
cannot be easily removed.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux