From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2R4B-0001jG-Kz for qemu-devel@nongnu.org; Thu, 15 Apr 2010 11:33:19 -0400 Received: from [140.186.70.92] (port=37030 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2R4A-0001i4-AC for qemu-devel@nongnu.org; Thu, 15 Apr 2010 11:33:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2R49-00021J-5Z for qemu-devel@nongnu.org; Thu, 15 Apr 2010 11:33:18 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:40369) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2R49-00020a-0E for qemu-devel@nongnu.org; Thu, 15 Apr 2010 11:33:17 -0400 Received: by pvd12 with SMTP id 12so841291pvd.4 for ; Thu, 15 Apr 2010 08:33:15 -0700 (PDT) Sender: Richard Henderson Message-ID: <4BC731A9.3010305@twiddle.net> Date: Thu, 15 Apr 2010 08:32:57 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 03/12] net: eepro100: replace qemu_format_nic_info_str by qemu_format_nic_info_dict References: <1271340427-12579-1-git-send-email-miguel.filho@gmail.com> <1271340427-12579-4-git-send-email-miguel.filho@gmail.com> In-Reply-To: <1271340427-12579-4-git-send-email-miguel.filho@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 04/15/2010 07:06 AM, Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > hw/eepro100.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/hw/eepro100.c b/hw/eepro100.c > index 7db6fb5..457bda8 100644 > --- a/hw/eepro100.c > +++ b/hw/eepro100.c > @@ -1978,8 +1978,14 @@ static int nic_init(PCIDevice *pci_dev, uint32_t device) > s->nic = qemu_new_nic(&net_eepro100_info,&s->conf, > pci_dev->qdev.info->name, pci_dev->qdev.id, s); > > - qemu_format_nic_info_str(&s->nic->nc, s->conf.macaddr.a); > - TRACE(OTHER, logout("%s\n", s->nic->nc.info_str)); > + qemu_format_nic_info_dict(&s->nic->nc, s->conf.macaddr.a); > + > +#ifdef DEBUG_EEPRO100 > + QString *qstring; > + qstring = qdict_to_qstring(s->nic->nc.info_dict); This isn't C++ or C99 -- declarations have to come at the start of a block. You need to add { } here inside the ifdef. r~