From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1O2TSr-0003HT-4h for mharc-grub-devel@gnu.org; Thu, 15 Apr 2010 14:06:57 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2TSo-0003Dm-Nw for grub-devel@gnu.org; Thu, 15 Apr 2010 14:06:54 -0400 Received: from [140.186.70.92] (port=37413 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2TSm-00039D-28 for grub-devel@gnu.org; Thu, 15 Apr 2010 14:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2Rq0-0000Lz-2F for grub-devel@gnu.org; Thu, 15 Apr 2010 12:23:17 -0400 Received: from mail-bw0-f225.google.com ([209.85.218.225]:48732) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2Rpz-0000Le-R8 for grub-devel@gnu.org; Thu, 15 Apr 2010 12:22:43 -0400 Received: by bwz25 with SMTP id 25so1606343bwz.8 for ; Thu, 15 Apr 2010 09:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=C2CYKbD2tQgb6YfoQjXH7vrLtH0hW6SpjFLW/Zj0xGU=; b=bW6UZLqwCCWWMHvm26x6idlMAbthZcNu+OnVfhjUmlymFvtw80WOII3mN0D1RNZQqa sGVj0IaOXVdK0g+8uKVwQH/WbW49KNjjml3wfBOY1w20aBmffBRci9cDnJgRdxme7vBS tJe56ZyyBQhwYzHJqaLzSnGortzgsaMhWiYpo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=e+rrw74gOQAKBgCEDDUykRIjj94dWMIkbcpiQ4lUAP+ORGgrCh+gYpqC5ZK5t+I+bC TGTWS6adgNNK8/TiAulZw82Fsg2z/gmg9Itag1m9dUlHWnGB5VOkDa1S8hx3HvbeML3c gbIwZRb0pwko6cK4YD5QweZsKtkxHT3/AP6OM= Received: by 10.204.163.16 with SMTP id y16mr299506bkx.177.1271348562485; Thu, 15 Apr 2010 09:22:42 -0700 (PDT) Received: from debian.bg45.phnet (gprs19.swisscom-mobile.ch [193.247.250.19]) by mx.google.com with ESMTPS id 16sm1296114bwz.13.2010.04.15.09.22.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 15 Apr 2010 09:22:40 -0700 (PDT) Message-ID: <4BC73D44.6020307@gmail.com> Date: Thu, 15 Apr 2010 18:22:28 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <87iq7wk74w.wl%jir@sekiba.com> In-Reply-To: <87iq7wk74w.wl%jir@sekiba.com> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig0963D6CBB9A90CA1D0EEEA62" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCHv3] a new filesystem module for nilfs2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2010 18:06:55 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0963D6CBB9A90CA1D0EEEA62 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jiro SEKIBA wrote: > Hi, > > This is a revised patch to support nilfs2, a log file system. > The patch is basically just a retrofit of the one I sent before > against current tree. > > I've checked it both on qemu and qemu-system-ppc with grub-fstest. > =20 Thanks for your effort. I recommend running indent on all new files + * Copyright (C) 2010 Jiro SEKIBA =20 + */ This should go into=20 + * Copyright (C) 2003,2004,2005,2007,2008,2010 Free Software Foundatio= n, Inc. Because of legal reason. You can of course add a notion like: /* Wrtitten by Jiro SEKIBA . */ +/* nilfs btree node flag */ Please add a full stop. Some of th +} __attribute__ ((packed)); Most structures in nilfs like in most modern FS need no __attribute__ ((p= acked)). And adding it inflicts performance penalty on RISC. +/** nilfs_fs.h **/ Your code doesn't look derived from any other nilfs implementation. I thi= nk these comments are only confusing. + { + s =3D 0; + goto out; + } I think it would be slightly more clear by putting *indexp =3D index; ret= urn 1; here. + /* assume sizeof(struct grub_nilfs2_cpfile_header) <=20 + sizeof(struct grub_nilfs2_checkpoint) + */ Capitalize and add a full stop please. + if(grub_errno) + { + grub_error(GRUB_ERR_BAD_FS,"disk read error\n"); + return -1; No need to run grub_error if grub_errno is already set + { + grub_error(GRUB_ERR_BAD_FS,"btree corruption\n"); + return -1; + } What do you think about possible fallback to iterate over all nodes in ca= se of fs corruption? + grub_error(GRUB_ERR_BAD_FS,"btree lookup failure"); + return GRUB_ERR_BAD_FS; can be just done with: return grub_error(GRUB_ERR_BAD_FS, "btree lookup failure"); > Thanks, > > Regards, > =20 > -----------------------------------------------------------------------= - > > > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig0963D6CBB9A90CA1D0EEEA62 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkvHPUoACgkQNak7dOguQgnSLAD/f8EmLRMglt+AY26oCOJRX8av QWSDFT8h62nNnnXgc2QA/1VDY3bZlftdh2Oi9YXyXX6qvEvtA3XXaFL1G4g6jzYi =P748 -----END PGP SIGNATURE----- --------------enig0963D6CBB9A90CA1D0EEEA62--