diff for duplicates of <4BC7CAC1.4000803@cn.fujitsu.com> diff --git a/a/content_digest b/N1/content_digest index 1c9892d..58f7e22 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,23 @@ + "ref\04BC70EF1.6080400@cn.fujitsu.com\0" + "ref\020100415151926.GA4813@gondor.apana.org.au\0" "From\0Shan Wei <shanwei@cn.fujitsu.com>\0" "Subject\0Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with\tskb->local_df\0" "Date\0Fri, 16 Apr 2010 02:26:09 +0000\0" - "To\0dccp@vger.kernel.org\0" + "To\0Herbert Xu <herbert@gondor.hengli.com.au>\0" + "Cc\0David Miller <davem@davemloft.net>" + yinghai.lu@oracle.com + kuznet@ms2.inr.ac.ru + pekkas@netcore.fi + jmorris@namei.org + yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> + Patrick McHardy <kaber@trash.net> + netdev@vger.kernel.org <netdev@vger.kernel.org> + dccp@vger.kernel.org + linux-sctp@vger.kernel.org + kleptog@svana.org + jchapman@katalix.com + mostrows@speakeasy.net + " acme@xconectiva.com.br\0" "\00:1\0" "b\0" "Herbert Xu wrote, at 04/15/2010 11:19 PM:\n" @@ -48,4 +64,4 @@ "> \n" > Cheers, -4f5ad59cc475b86017006ca6456abdcd3898f907dcc873178d1826d58ccc8db2 +11caa03b56afaae658fa20e5816882f75b87f6a4d05bb15efdd9b815e2fe30d9
diff --git a/a/1.txt b/N2/1.txt index 363ce11..9f0e3af 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -19,18 +19,18 @@ Herbert Xu wrote, at 04/15/2010 11:19 PM: >> iph->frag_off = 0; > > This hunk looked suspecious at first. However, it is OK because -> ever calls this with ipfragok = 1, or local_df = 1. +> ever calls this with ipfragok == 1, or local_df == 1. > > The first is obvious from this patch itself, the second not quite > so obvious. > -> As nobody calls it with local_df = 1 anyway, and strictly speaking +> As nobody calls it with local_df == 1 anyway, and strictly speaking > local_df shouldn't be set at all by the caller of ip_queue_xmit, we > should simply remove the && ... bit and have > > if (ip_dont_fragment(sk, &rt->u.dst)) -Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1. +Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok == 1. So, now we can't remove the && ... bit. diff --git a/a/content_digest b/N2/content_digest index 1c9892d..a31133c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,7 +1,23 @@ + "ref\04BC70EF1.6080400@cn.fujitsu.com\0" + "ref\020100415151926.GA4813@gondor.apana.org.au\0" "From\0Shan Wei <shanwei@cn.fujitsu.com>\0" "Subject\0Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with\tskb->local_df\0" - "Date\0Fri, 16 Apr 2010 02:26:09 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Date\0Fri, 16 Apr 2010 10:26:09 +0800\0" + "To\0Herbert Xu <herbert@gondor.hengli.com.au>\0" + "Cc\0David Miller <davem@davemloft.net>" + yinghai.lu@oracle.com + kuznet@ms2.inr.ac.ru + pekkas@netcore.fi + jmorris@namei.org + yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> + Patrick McHardy <kaber@trash.net> + netdev@vger.kernel.org <netdev@vger.kernel.org> + dccp@vger.kernel.org + linux-sctp@vger.kernel.org + kleptog@svana.org + jchapman@katalix.com + mostrows@speakeasy.net + " acme@xconectiva.com.br\0" "\00:1\0" "b\0" "Herbert Xu wrote, at 04/15/2010 11:19 PM:\n" @@ -25,18 +41,18 @@ ">> \t\tiph->frag_off = 0;\n" "> \n" "> This hunk looked suspecious at first. However, it is OK because\n" - "> ever calls this with ipfragok = 1, or local_df = 1.\n" + "> ever calls this with ipfragok == 1, or local_df == 1.\n" "> \n" "> The first is obvious from this patch itself, the second not quite\n" "> so obvious.\n" "> \n" - "> As nobody calls it with local_df = 1 anyway, and strictly speaking\n" + "> As nobody calls it with local_df == 1 anyway, and strictly speaking\n" "> local_df shouldn't be set at all by the caller of ip_queue_xmit, we\n" "> should simply remove the && ... bit and have \n" "> \n" "> \tif (ip_dont_fragment(sk, &rt->u.dst))\n" "\n" - "Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1.\n" + "Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok == 1.\n" "So, now we can't remove the && ... bit. \n" "\n" "\n" @@ -48,4 +64,4 @@ "> \n" > Cheers, -4f5ad59cc475b86017006ca6456abdcd3898f907dcc873178d1826d58ccc8db2 +b73ea8405e6ec6d6f8c36c6330d5a47cc75c3129e00292312ac76e2aca389bb8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.