From: Tomas Carnecky <tom@dbservice.com>
To: Heikki Orsila <shdl@zakalwe.fi>
Cc: git@vger.kernel.org
Subject: Re: A bug in git 1.6.5.2 with git log --stat: shows a negative number as a size
Date: Fri, 16 Apr 2010 17:02:01 +0200 [thread overview]
Message-ID: <4BC87BE9.9040704@dbservice.com> (raw)
In-Reply-To: <20100416135948.GA26918@zakalwe.fi>
On 4/16/10 3:59 PM, Heikki Orsila wrote:
> I'm running git version 1.6.5.2. git log --stat shows a negative
> diffstat size for two files that are each 2049MiB in size.
>
> Steps to reproduce:
>
> $ for f in 0 1 ; do dd bs=$((1024*1024)) if=/dev/zero of=$f count=2049 ; done
> $ git add 0 1
> $ git commit -m "test commit"
> $ git log --stat
> commit 6afe3d3c889daa92bd79956c4bb733eb5cb408dc
> Author: Heikki Orsila<heikki.orsila@iki.fi>
> Date: 2010-04-16 16:54:52 +0300
>
> test commit
>
> 0 | Bin 0 -> -2146435072 bytes
> 1 | Bin 0 -> -2146435072 bytes
> 2 files changed, 0 insertions(+), 0 deletions(-)
Yep, bug is also in the latest version (1.7.0.5). The code uses 'int'
instead of something big enough to hold the size of your files.
http://git.kernel.org/?p=git/git.git;a=blob;f=diff.c;h=a1bf1e9cb37104cda8168c5118769ce5bbcfcbb2;hb=HEAD#l1105
and a couple lines below (1124) you see that the stat is printed out.
tom
next prev parent reply other threads:[~2010-04-16 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 13:59 A bug in git 1.6.5.2 with git log --stat: shows a negative number as a size Heikki Orsila
2010-04-16 15:02 ` Tomas Carnecky [this message]
2010-04-17 10:25 ` [PATCH] diff: use 64-bit integers for diffstat calculations Jeff King
2010-04-17 17:00 ` Junio C Hamano
2010-04-17 17:41 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC87BE9.9040704@dbservice.com \
--to=tom@dbservice.com \
--cc=git@vger.kernel.org \
--cc=shdl@zakalwe.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.