All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <esandeen@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] 125 run ftrunc with relative path
Date: Fri, 16 Apr 2010 10:48:55 -0500	[thread overview]
Message-ID: <4BC886E7.3030606@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1004160924090.2710@localhost>

On 04/16/2010 02:27 AM, Lukas Czerner wrote:
> From 16588d733e681954386f1b92dd6e47cfef92a207 Mon Sep 17 00:00:00 2001
> From: Lukas Czerner <lczerner@redhat.com>
> Date: Tue, 13 Apr 2010 19:34:07 +0200
> Subject: [PATCH] 125 run ftrunc with relative path
> 
> Since ftrunc is invoked with su $qa_user, it can fail when absolute path
> is not accessible to everyone.

Looks right to me.

After talking w/ you on IRC, I'll take the liberty of adding your
signed-off-by: to the patch, and check it in with my reviewed-by:

Thanks,
-Eric

> ---
>  125 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/125 b/125
> index e84109a..9a29941 100755
> --- a/125
> +++ b/125
> @@ -61,7 +61,7 @@ touch $TESTFILE
>  chmod a+rw $TESTDIR
>  chmod a+rw $TESTFILE
>  
> -su $qa_user -c "$here/src/ftrunc -f $TESTFILE"
> +su $qa_user -c "./src/ftrunc -f $TESTFILE"
>  
>  if [ "$?" != "0" ];  then
>      echo src/ftrunc returned non 0 status!

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-04-16 15:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-16  7:27 [PATCH] 125 run ftrunc with relative path Lukas Czerner
2010-04-16 15:48 ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC886E7.3030606@redhat.com \
    --to=esandeen@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.