From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix Date: Fri, 16 Apr 2010 14:51:22 -0600 Message-ID: <4BC8CDCA.1000703@novell.com> References: <4BC8547A020000780003A98D@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020107070706060908050002" Return-path: In-Reply-To: <4BC8547A020000780003A98D@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------020107070706060908050002 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Jan Beulich wrote: > Perhaps this should even be further generalized (e.g. to remove any > "[!/]*:" pattern prefixes) to be more forward compatible? > Right. Need to handle the 'ioemu' subtype as well. How about just stripping of everything before the leading '/'? E.g. like the attached patch? Regards, Jim --------------020107070706060908050002 Content-Type: text/x-patch; name="blktap-script.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="blktap-script.patch" diff -r c02cc832cb2d tools/hotplug/Linux/blktap --- a/tools/hotplug/Linux/blktap Tue Apr 13 18:19:33 2010 +0100 +++ b/tools/hotplug/Linux/blktap Fri Apr 16 14:48:00 2010 -0600 @@ -59,10 +59,10 @@ if [ -n "$t" ] then p=$(xenstore_read "$XENBUS_PATH/params") - # if we have a ':', chew from head including : + # if we have a ':', remove everything up to leading '/' if echo $p | grep -q \: then - p=${p#*:} + p="/${p#*/}" fi fi # some versions of readlink cannot be passed a regular file --------------020107070706060908050002 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------020107070706060908050002--