From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1O3Abp-0005eI-3g for mharc-grub-devel@gnu.org; Sat, 17 Apr 2010 12:11:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O3Abm-0005dc-V9 for grub-devel@gnu.org; Sat, 17 Apr 2010 12:11:03 -0400 Received: from [140.186.70.92] (port=52288 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O3Abl-0005co-8m for grub-devel@gnu.org; Sat, 17 Apr 2010 12:11:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O3Abk-0004Gd-2z for grub-devel@gnu.org; Sat, 17 Apr 2010 12:11:01 -0400 Received: from mailout07.t-online.de ([194.25.134.83]:39150) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O3Abj-0004GN-KY for grub-devel@gnu.org; Sat, 17 Apr 2010 12:11:00 -0400 Received: from fwd09.aul.t-online.de (fwd09.aul.t-online.de ) by mailout07.t-online.de with smtp id 1O3Abh-0006fu-Ao; Sat, 17 Apr 2010 18:10:57 +0200 Received: from [192.168.2.100] (Z4maCkZArhaQ+mAsBMNa8vPzc6onQ6I-QQTPlI9KTB-NTo1l5SANDJOx+PO-rH9QSZ@[217.235.212.215]) by fwd09.aul.t-online.de with esmtp id 1O3AbW-1BYa800; Sat, 17 Apr 2010 18:10:46 +0200 Message-ID: <4BC9DD7F.3030701@t-online.de> Date: Sat, 17 Apr 2010 18:10:39 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100317 SeaMonkey/2.0.4 MIME-Version: 1.0 To: The development of GNU GRUB References: <4BC60B1D.8080609@t-online.de> <4BC9D233.9090307@gmail.com> In-Reply-To: <4BC9D233.9090307@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ID: Z4maCkZArhaQ+mAsBMNa8vPzc6onQ6I-QQTPlI9KTB-NTo1l5SANDJOx+PO-rH9QSZ X-TOI-MSGID: 3667b23c-2bb9-4557-9352-5079f2da184b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix Cygwin path handling X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Apr 2010 16:11:03 -0000 Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Christian Franke wrote: > >> The Cywin path handling is broken since >> make_system_path_relative_to_its_root() functionality was moved from >> the lib script to misc.c. >> >> This patch should fix this. It reuses the Cygwin specific code from >> getroot.c:grub_get_prefix() which apparently is a different >> implementation of the same function. >> >> I would suggest to remove grub_get_prefix(), it is now only used in >> grub-emu.c and sparc64/ieee1275/grub-setup.c. Not included in the >> patch, should be done in a separate commit. >> >> >> 2010-04-14 Christian Franke >> >> * util/grub-mkconfig_lib.in (make_system_path_relative_to_its_root): >> Remove broken Cygwin path conversion. >> * util/misc.c: [__CYGWIN__] Add include and define. >> [__CYGWIN__] (get_win32_path): Copy function from getroot.c, modify >> for Cygwin 1.7. >> > Please avoid duplicating code. Rather than that rename get_win32_path to > grub_get_win32_path and remove static attribute > Normally I would have done that but duplication was intentional in this case: The getroot.c:get_win32_path() can later be removed together with grub_get_prefix(), see my suggestion above. The patch takes this into account and adds new private misc.c:get_win32_path() and so avoids unnecessary temporary changes to misc.h and getroot.c. The actual code duplication happened when misc.c:make_system_path_relative_to_its_root() was added instead of moving and reusing getroot.c:grub_get_prefix() :-) BTW: My last commits to grub codebase were before the move to bzr. As far as I understand "Bazaar workflow for GRUB" (http://lists.gnu.org/archive/html/grub-devel/2010-01/msg00175.html) such changes should be 'bzr push'ed to e.g. '.../branches/feature-foo' (e.g. '.../branches/cygwin-path' in this case) after review has finished. Is this workflow still valid or is there a more current document? -- Regards, Christian Franke