From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1O3F6k-0001Hh-1u for mharc-grub-devel@gnu.org; Sat, 17 Apr 2010 16:59:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O3F6i-0001GH-9d for grub-devel@gnu.org; Sat, 17 Apr 2010 16:59:16 -0400 Received: from [140.186.70.92] (port=40909 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O3F6g-0001Ej-19 for grub-devel@gnu.org; Sat, 17 Apr 2010 16:59:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O3F6d-0003O7-3b for grub-devel@gnu.org; Sat, 17 Apr 2010 16:59:13 -0400 Received: from mail-bw0-f225.google.com ([209.85.218.225]:43567) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O3F6c-0003Ny-UC for grub-devel@gnu.org; Sat, 17 Apr 2010 16:59:11 -0400 Received: by bwz25 with SMTP id 25so3614697bwz.8 for ; Sat, 17 Apr 2010 13:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=VCsZToTSq0ezcmPvETIXvLqfjIQC3WpO5PfoFyEKLps=; b=t8B3Bnh4tP3ZywtTyy8UwrSpXKP05o06nYHICjd4dVnxnv11MwcdHU+ybDg31q8b4B CccCoBb61MT3yoXhdZYn/o8HgdW9B1UtLgSWR5SpvrceLjuwcnr2NoHZ587shu6SoLnD F4tkVVjTl9HnDEp5CTV7EYhOm0YYmtCTc3mOE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=ig4VXFhYnJi0WcVO1eaqcHovEPutFqmqc11aSx6m/t+J8h6tKTC6kZOGbU+b2nmR/T qH1N7Mw830p/oqoQy7w8zw6cGwFZgKnHUrStYv+AJXAEyN0HvY5v9W7Kaw++d+fW6nkQ FL00d9YA/yo9DbDoI8pSInToedqIpZZGlfU8Y= Received: by 10.204.46.153 with SMTP id j25mr2892465bkf.191.1271537949803; Sat, 17 Apr 2010 13:59:09 -0700 (PDT) Received: from debian.bg45.phnet (52.115.63.81.cust.bluewin.ch [81.63.115.52]) by mx.google.com with ESMTPS id 16sm2447800bwz.13.2010.04.17.13.59.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 17 Apr 2010 13:59:09 -0700 (PDT) Message-ID: <4BCA2113.10905@gmail.com> Date: Sat, 17 Apr 2010 22:58:59 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <4BC60B1D.8080609@t-online.de> <4BC9D233.9090307@gmail.com> <4BC9DD7F.3030701@t-online.de> In-Reply-To: <4BC9DD7F.3030701@t-online.de> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigE6C37F7A08A41502A6AB49FF" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Fix Cygwin path handling X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Apr 2010 20:59:17 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE6C37F7A08A41502A6AB49FF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Christian Franke wrote: > Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: >> Christian Franke wrote: >> =20 >>> The Cywin path handling is broken since >>> make_system_path_relative_to_its_root() functionality was moved from >>> the lib script to misc.c. >>> >>> This patch should fix this. It reuses the Cygwin specific code from >>> getroot.c:grub_get_prefix() which apparently is a different >>> implementation of the same function. >>> >>> I would suggest to remove grub_get_prefix(), it is now only used in >>> grub-emu.c and sparc64/ieee1275/grub-setup.c. Not included in the >>> patch, should be done in a separate commit. >>> >>> >>> 2010-04-14 Christian Franke >>> >>> * util/grub-mkconfig_lib.in >>> (make_system_path_relative_to_its_root): >>> Remove broken Cygwin path conversion. >>> * util/misc.c: [__CYGWIN__] Add include and define. >>> [__CYGWIN__] (get_win32_path): Copy function from getroot.c, >>> modify >>> for Cygwin 1.7. >>> =20 >> Please avoid duplicating code. Rather than that rename get_win32_path = to >> grub_get_win32_path and remove static attribute >> =20 > > Normally I would have done that but duplication was intentional in > this case: > The getroot.c:get_win32_path() can later be removed together with > grub_get_prefix(), see my suggestion above. The patch takes this into > account and adds new private misc.c:get_win32_path() and so avoids > unnecessary temporary changes to misc.h and getroot.c. > > The actual code duplication happened when > misc.c:make_system_path_relative_to_its_root() was added instead of > moving and reusing getroot.c:grub_get_prefix() :-) > Ok. Can you supply the dedup patch? (perhaps it should come before the fi= x). > > BTW: My last commits to grub codebase were before the move to bzr. > > As far as I understand "Bazaar workflow for GRUB" > (http://lists.gnu.org/archive/html/grub-devel/2010-01/msg00175.html) > such changes should be 'bzr push'ed to e.g. '.../branches/feature-foo' > (e.g. '.../branches/cygwin-path' in this case) after review has finishe= d. > Creating new branches doesn't need any approval at all. If the changes are approved for trunk they are applied or merged into trunk. experimental branch is a merge of sufficiently functional branches but which need more testing for testers convenience. Merging into it follows similar rules as comitting to trunk. > Is this workflow still valid or is there a more current document? > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigE6C37F7A08A41502A6AB49FF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkvKIRkACgkQNak7dOguQgncQgEAvpudu6lJHwA8KArkHiOP/HvT j5013+hIdQwOZvTwsvQA/Av5nSrjKMCgG/wTZUOSQ50steVwZq2RGGDHWJiHb/1D =py3X -----END PGP SIGNATURE----- --------------enigE6C37F7A08A41502A6AB49FF--