From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi
Date: Sat, 17 Apr 2010 21:46:18 -0700
Message-ID: <4BCA8E9A.6090209@goop.org>
References: <4BC7C657.3010609@cn.fujitsu.com>
	<20100416145604.GC29398@phenom.dumpdata.com>
	<4BCA82FF.20901@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4BCA82FF.20901@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Yu Zhiguo <yuzg@cn.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 04/17/2010 08:56 PM, Yu Zhiguo wrote:
> Konrad Rzeszutek Wilk wrote:
>   
>> On Fri, Apr 16, 2010 at 10:07:19AM +0800, Yu Zhiguo wrote:
>>     
>>> routines 'xen_register_gsi' and 'xen_teardown_msi_dev' cannot be used
>>> unless macro 'CONFIG_XEN' is defined, otherwise build error occurs.
>>>       
>> There has to be a better of doing this. Aren't the
>> xen_register_gsi defined in the header files? How about making in the
>> header file the #ifdef CONFIG_XEN there?
>>
>>
>>     
> In fact, 'xen_register_gsi' is declared in header file 'asm/xen/pci.h'
> with '#ifdef CONFIG_XEN', please refer to the following code.
>
> So 'acpi/boot.c' can use it but should check '#ifdef CONFIG_XEN'.
> What's your opinion?
>
> -----------------------asm/xen/pci.h----------------------
> #ifdef CONFIG_XEN
> ...
> #ifdef CONFIG_XEN_DOM0_PCI
> int xen_register_gsi(u32 gsi, int triggering, int polarity);
> ...
> #else
> static inline int xen_register_gsi(u32 gsi, int triggering, int polarity)
> {
>         return -1;
> }
> ...
>   

This is a good way of handling it.

    J