From: John Hughes <john@Calva.COM>
To: Andrew Hendry <andrew.hendry@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/6] X25: Use identifiers for X25 to device interface
Date: Sun, 18 Apr 2010 12:55:05 +0200 [thread overview]
Message-ID: <4BCAE509.9000209@Calva.COM> (raw)
In-Reply-To: <1271584310.6280.425.camel@ibex>
Andrew Hendry wrote:
> Use identifiers in x25_device.h instead of magic numbers for X25 layer 3 to device interface.
> Also fixed checkpatch notes on updated code.
> [...]
>
> -First Byte = 0x00
> +First Byte = 0x00 (X25_IFACE_DATA)
> [...]
> +
> +enum {
> + X25_IFACE_DATA,
> + X25_IFACE_CONNECT,
> + X25_IFACE_DISCONNECT,
> + X25_IFACE_PARAMS
> +};
>
Shouldn't you use explicit values here?
enum {
X25_IFACE_DATA = 0x00, /* explicit value for ABI stability */
...
next prev parent reply other threads:[~2010-04-18 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 9:51 [PATCH 1/6] X25: Use identifiers for X25 to device interface Andrew Hendry
2010-04-18 10:55 ` John Hughes [this message]
2010-04-18 11:08 ` John Hughes
2010-04-18 23:51 ` andrew hendry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCAE509.9000209@Calva.COM \
--to=john@calva.com \
--cc=andrew.hendry@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.