From: Richard Henderson <rth@twiddle.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.
Date: Sun, 18 Apr 2010 10:02:53 -0500 [thread overview]
Message-ID: <4BCB1F1D.1020202@twiddle.net> (raw)
In-Reply-To: <g2zf43fc5581004171141ia036377bu94085403607ba2c1@mail.gmail.com>
On 04/17/2010 01:41 PM, Blue Swirl wrote:
> Yes, but we would still gain the small optimizations for add by 0, and
> with 0xffffffff etc. in tcg-op.h. Sparc QEMU target generates a lot of
> those because of poor constant formation choices made by the guest
> compilers.
Another thing that gets fixed by Aurelien's constant prop patch.
Don't think that Sparc is alone in generating x+0 in a way that
gets past the tcg-op.h checks.
> By the way, do you think constant pool approach (put constants at the
> end of TB) would be useful, especially for 64 bit constants?
Probably.
The support for that could probably be leveraged to move the TLB
miss code path out of line as well.
r~
prev parent reply other threads:[~2010-04-18 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 14:50 [Qemu-devel] [PATCH 1/3] target-sparc: Fix TARGET_{PHYS, VIRT}_ADDR_SPACE_BITS Richard Henderson
2010-04-16 14:50 ` [Qemu-devel] [PATCH 2/3] target-sparc: Free instruction temporaries Richard Henderson
2010-04-16 14:50 ` [Qemu-devel] [PATCH 3/3] Fix --enable-profiler compilation Richard Henderson
2010-04-17 16:41 ` [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries Blue Swirl
2010-04-17 17:49 ` Richard Henderson
2010-04-17 18:00 ` Richard Henderson
2010-04-17 18:50 ` Blue Swirl
2010-04-17 18:41 ` Blue Swirl
2010-04-18 15:02 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCB1F1D.1020202@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.