From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Mon, 19 Apr 2010 08:41:55 +0000 Subject: Re: [PATCH 5/8] KVM: PPC: Be more informative on BUG Message-Id: <4BCC1753.7080105@redhat.com> List-Id: References: <1271633816-7863-1-git-send-email-agraf@suse.de> <1271633816-7863-6-git-send-email-agraf@suse.de> <20100419010125.GA10309@psychosis.jim.sh> <9B8FF539-36C7-4976-87B0-DF5A75492C92@suse.de> <6F7AA5B9-AE83-494B-99C2-22BCF927D4EC@suse.de> In-Reply-To: <6F7AA5B9-AE83-494B-99C2-22BCF927D4EC-l3A5Bk7waGM@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Jim Paris , kvm-ppc , kvm-devel list On 04/19/2010 04:26 AM, Alexander Graf wrote: > >> Very true. In fact, I certainly remember me putting a return and a WARN_ON(true) because WARN() gave me a warning here. I wonder where that code went ... hrm ... >> Either way, thanks for looking over this patch! >> > Ugh - I messed up my patch rebasing. The hunk to put the return there is included in 6/8. > > Oh well, I don't think that's enough of a bummer for a resubmit. Avi, please apply this set nevertheless. > > I don't see it in 6/8. Please fix it up regardless, I run bisectability tests on submissions and don't want to puzzle out any warnings. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/8] KVM: PPC: Be more informative on BUG Date: Mon, 19 Apr 2010 11:41:55 +0300 Message-ID: <4BCC1753.7080105@redhat.com> References: <1271633816-7863-1-git-send-email-agraf@suse.de> <1271633816-7863-6-git-send-email-agraf@suse.de> <20100419010125.GA10309@psychosis.jim.sh> <9B8FF539-36C7-4976-87B0-DF5A75492C92@suse.de> <6F7AA5B9-AE83-494B-99C2-22BCF927D4EC@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jim Paris , kvm-ppc , kvm-devel list To: Alexander Graf Return-path: In-Reply-To: <6F7AA5B9-AE83-494B-99C2-22BCF927D4EC-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 04/19/2010 04:26 AM, Alexander Graf wrote: > >> Very true. In fact, I certainly remember me putting a return and a WARN_ON(true) because WARN() gave me a warning here. I wonder where that code went ... hrm ... >> Either way, thanks for looking over this patch! >> > Ugh - I messed up my patch rebasing. The hunk to put the return there is included in 6/8. > > Oh well, I don't think that's enough of a bummer for a resubmit. Avi, please apply this set nevertheless. > > I don't see it in 6/8. Please fix it up regardless, I run bisectability tests on submissions and don't want to puzzle out any warnings. -- error compiling committee.c: too many arguments to function