From: Avi Kivity <avi@redhat.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org
Subject: Re: [BUG] kvm: dereference srcu-protected pointer without srcu_read_lock() held
Date: Mon, 19 Apr 2010 13:08:29 +0300 [thread overview]
Message-ID: <4BCC2B9D.8050008@redhat.com> (raw)
In-Reply-To: <4BCC295D.1040807@cn.fujitsu.com>
On 04/19/2010 12:58 PM, Lai Jiangshan wrote:
> Applied the patch I just sent and let CONFIG_PROVE_RCU=y,
> we can got the following dmesg. And we found that it is
> because some codes in KVM dereferences srcu-protected pointer without
> srcu_read_lock() held or update-side lock held.
>
> It is not hard to fix, the problem is that:
> Where is the most proper place to put a srcu_read_lock()?
>
> I can not determine the answer, so I report this bug
> instead of fixing it.
>
>
I think the else branch in complete_pio() should work. Marcelo?
Longer term I'd like to see the lock taken at the high levels (ioctls,
in virt/kvm) and dropped only for guest entry and when we explicitly
sleep (hlt emulation).
Note: complete_pio() is gone in the current code.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-04-19 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 9:41 [PATCH] kvm: use the correct RCU API Lai Jiangshan
2010-04-19 9:41 ` Lai Jiangshan
2010-04-19 9:49 ` Avi Kivity
2010-04-19 23:35 ` Paul E. McKenney
2010-04-20 2:09 ` Lai Jiangshan
2010-04-20 18:42 ` Paul E. McKenney
2010-04-19 9:58 ` [BUG] kvm: dereference srcu-protected pointer without srcu_read_lock() held Lai Jiangshan
2010-04-19 10:08 ` Avi Kivity [this message]
2010-04-20 1:45 ` Marcelo Tosatti
2010-04-20 6:29 ` Lai Jiangshan
2010-04-20 22:21 ` Paul E. McKenney
2010-04-21 8:17 ` Avi Kivity
2010-04-21 14:36 ` Paul E. McKenney
2010-04-20 21:55 ` [PATCH] kvm: use the correct RCU API Paul E. McKenney
2010-04-21 8:22 ` Avi Kivity
2010-04-21 8:22 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCC2B9D.8050008@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.