From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O3o9R-0000Hj-9L for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:24:25 -0400 Received: from [140.186.70.92] (port=46732 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O3o9O-0000Fe-L4 for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:24:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O3o9I-00071R-1K for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:24:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61132) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O3o9H-00071H-6Z for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:24:15 -0400 Message-ID: <4BCC2F49.2000300@redhat.com> Date: Mon, 19 Apr 2010 13:24:09 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1271670198-12793-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> In-Reply-To: <1271670198-12793-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 0/6] Introduce bit-based phys_ram_dirty, and bit-based dirty page checker. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: aliguori@us.ibm.com, mtosatti@redhat.com, qemu-devel@nongnu.org, ohmura.kei@lab.ntt.co.jp On 04/19/2010 12:43 PM, Yoshiaki Tamura wrote: > The dirty and non-dirty pages are checked one by one. When most of the memory > is not dirty, checking the dirty and non-dirty pages by multiple page size > should be much faster than checking them one by one. We introduced bit-based > phys_ram_dirty for VGA, CODE, MIGRATION, MASTER, and > cpu_physical_memory_get_dirty_range() for this purpose. > > Apart from my minor comments to patches 1 and 2 this looks ready to merge. -- error compiling committee.c: too many arguments to function