From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O3oMe-0001bJ-PY
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:38:05 -0400
Received: from [140.186.70.92] (port=55336 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O3oMc-0001a0-Sp
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:38:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <tamura.yoshiaki@lab.ntt.co.jp>) id 1O3oMa-0001LK-7W
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:38:02 -0400
Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:44656)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <tamura.yoshiaki@lab.ntt.co.jp>) id 1O3oMZ-0001Kj-In
	for qemu-devel@nongnu.org; Mon, 19 Apr 2010 06:38:00 -0400
Message-ID: <4BCC3281.5040708@lab.ntt.co.jp>
Date: Mon, 19 Apr 2010 19:37:53 +0900
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
MIME-Version: 1.0
References: <1271670198-12793-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>
	<4BCC2F49.2000300@redhat.com>
In-Reply-To: <4BCC2F49.2000300@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3 0/6] Introduce bit-based phys_ram_dirty,
 and bit-based dirty page checker.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: aliguori@us.ibm.com, mtosatti@redhat.com, qemu-devel@nongnu.org, ohmura.kei@lab.ntt.co.jp

Avi Kivity wrote:
> On 04/19/2010 12:43 PM, Yoshiaki Tamura wrote:
>> The dirty and non-dirty pages are checked one by one. When most of the
>> memory
>> is not dirty, checking the dirty and non-dirty pages by multiple page
>> size
>> should be much faster than checking them one by one. We introduced
>> bit-based
>> phys_ram_dirty for VGA, CODE, MIGRATION, MASTER, and
>> cpu_physical_memory_get_dirty_range() for this purpose.
>>
>
> Apart from my minor comments to patches 1 and 2 this looks ready to merge.

Thank you for reviewing.
I would apply your comments, and post as v4.