All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: xenomai-core <xenomai@xenomai.org>
Subject: [Xenomai-core] [RFC] fix XENO_OPT_DEBUG bugs.
Date: Mon, 19 Apr 2010 15:58:54 +0200	[thread overview]
Message-ID: <4BCC619E.2@domain.hid> (raw)


Hi,

I found some code which was referencing directly some
CONFIG_XENO_OPT_DEBUG_ variables with things like:

#ifdef CONFIG_XENO_OPT_DEBUG_FOO

This usage is incompatible with the pre-requisites of the assert.h
header that CONFIG_XENO_OPT_DEBUG_FOO should be defined at all times.
While grepping for CONFIG_XENO_OPT_DEBUG_, I found that we also have
many duplicates of construction like:
#ifndef CONFIG_XENO_OPT_DEBUG_FOO
#define CONFIG_XENO_OPT_DEBUG_FOO 0
#endif /* CONFIG_XENO_OPT_DEBUG_FOO */

So, a patch follows which:
- replace the #ifdef with some #if XENO_DEBUG(FOO)
- move all the initializations to assert.h

This will make any reference to CONFIG_XENO_OPT_DEBUG_FOO outside of
assert.h suspicious, and easy to detect.

Thanks in advance for any comments.
Regards.

-- 
					    Gilles.


             reply	other threads:[~2010-04-19 13:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19 13:58 Gilles Chanteperdrix [this message]
2010-04-19 14:00 ` [Xenomai-core] [PATCH] debug: fix direct references to CONFIG_XENO_OPT_DEBUG_* Gilles Chanteperdrix
2010-04-19 14:05 ` [Xenomai-core] [RFC] fix XENO_OPT_DEBUG bugs Gilles Chanteperdrix
2010-04-19 14:47 ` Jan Kiszka
2010-04-19 14:52   ` Gilles Chanteperdrix
2010-04-19 15:02     ` Jan Kiszka
2010-04-19 15:07       ` Gilles Chanteperdrix
2010-04-19 15:33         ` Jan Kiszka
2010-04-19 15:37           ` Gilles Chanteperdrix
2010-04-19 15:58             ` Jan Kiszka
2010-04-19 16:10               ` Philippe Gerum
2010-04-19 16:14                 ` Jan Kiszka
2010-04-19 16:25                   ` Philippe Gerum
2010-04-19 16:43                     ` Philippe Gerum
2010-04-19 17:22                       ` Jan Kiszka
2010-04-19 17:23                         ` Philippe Gerum
2010-04-19 17:27                         ` Philippe Gerum
2010-04-19 16:27                   ` Gilles Chanteperdrix
2010-04-19 17:21                     ` Jan Kiszka
2010-04-19 17:26                       ` Gilles Chanteperdrix
2010-04-19 17:43                         ` Jan Kiszka
2010-04-19 17:56                           ` Gilles Chanteperdrix
2010-04-19 18:03                           ` Gilles Chanteperdrix
2010-04-19 18:14                             ` Gilles Chanteperdrix
2010-04-19 18:18                               ` Jan Kiszka
2010-04-19 18:22                                 ` Gilles Chanteperdrix
2010-04-19 18:38                                   ` Jan Kiszka
2010-04-19 18:41                                     ` Gilles Chanteperdrix
2010-04-19 19:08                                       ` Jan Kiszka
2010-04-19 19:21                                         ` Gilles Chanteperdrix
2010-04-19 19:37                                           ` Jan Kiszka
2010-04-19 19:47                                             ` Gilles Chanteperdrix
2010-04-19 20:08                                               ` Jan Kiszka
2010-04-19 20:33                                                 ` Gilles Chanteperdrix
2010-04-19 19:55                                             ` Gilles Chanteperdrix
2010-04-20 12:48   ` Gilles Chanteperdrix
2010-04-20 14:02     ` Gilles Chanteperdrix
2010-04-19 15:06 ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCC619E.2@domain.hid \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.