From: Stefan Weil <weil@mail.berlios.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Benjamin Drung <bdrung@ubuntu.com>,
Aurelien Jarno <aurelien@aurel32.net>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] wrong behaviour of caps lock
Date: Mon, 19 Apr 2010 18:07:57 +0200 [thread overview]
Message-ID: <4BCC7FDD.3000902@mail.berlios.de> (raw)
In-Reply-To: <4BCC168C.2080800@redhat.com>
Kevin Wolf schrieb:
> Am 19.04.2010 03:23, schrieb Jamie Lokier:
>> Benjamin Drung wrote:
>>> - /* SDL does not send the key up event, so we generate it */
>> Was the original comment just plain wrong?
>>
>>> - kbd_put_keycode(keycode);
>>> - kbd_put_keycode(keycode | 0x80);
>>> + if (ev->type == SDL_KEYUP) {
>>> + kbd_put_keycode(keycode | 0x80);
>>> + } else {
>>> + kbd_put_keycode(keycode);
>>> + }
>> The patch implies that SDL *does* send the key up event.
>>
>> Somebody obviously thought that it doesn't, hence the comment.
>>
>> So what has changed? Is it different versions of SDL, or does the
>> patch only work on some hosts / distros?
>
> I think we already have had a discussion on this and it turned out that
> Ubuntu had a "special" version of SDL which changed this behaviour. So
> it is considered an Ubuntu SDL bug. Googled the old discussion for you:
>
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg25246.html
>
> Kevin
My report was based on the Debian testing distribution
with libsdl components version 1.2.13-5.
So if it's a bug, both Ubuntu and Debian share it
(which is not too surprising).
And as I explained in my previous mail on this thread
QEMU's caps lock handling is buggy on any distribution.
Maybe I'll find the time to write a patch until the end
of this week.
Stefan
next prev parent reply other threads:[~2010-04-19 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 16:02 [Qemu-devel] wrong behaviour of caps lock Benjamin Drung
2010-04-17 9:59 ` Stefan Weil
2010-04-19 1:23 ` Jamie Lokier
2010-04-19 8:38 ` Kevin Wolf
2010-04-19 16:07 ` Stefan Weil [this message]
2010-11-18 23:58 ` Benjamin Drung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCC7FDD.3000902@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=aurelien@aurel32.net \
--cc=bdrung@ubuntu.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.