From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi
Date: Mon, 19 Apr 2010 09:22:26 -0700
Message-ID: <4BCC8342.5080003@goop.org>
References: <4BC7C657.3010609@cn.fujitsu.com>
	<20100416145604.GC29398@phenom.dumpdata.com>
	<4BCA82FF.20901@cn.fujitsu.com> <4BCA8E9A.6090209@goop.org>
	<20100419133026.GA17501@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20100419133026.GA17501@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Yu Zhiguo <yuzg@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On 04/19/2010 06:30 AM, Konrad Rzeszutek Wilk wrote:
>>> ...
>>>   
>>>       
>> This is a good way of handling it.
>>     
> The header file change or the #ifdef in the acpi/boot.c file?
>   

Adding stub static inlines is almost always preferable to open-coded
#ifdefs in .c files.  But we're growing a bit of an #ifdef thicket in
there...

    J