From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time
Date: Mon, 19 Apr 2010 15:19:24 -0500 [thread overview]
Message-ID: <4BCCBACC.6050801@freescale.com> (raw)
In-Reply-To: <20100419152345.0cb17200.kim.phillips@freescale.com>
Kim Phillips wrote:
> On Fri, 16 Apr 2010 20:06:02 +0300
> Michael Zaidman <michael.zaidman@gmail.com> wrote:
>
>> On Fri, Apr 16, 2010 at 1:36 AM, Kim Phillips
>> <kim.phillips@freescale.com> wrote:
>>> before, MPC8349ITX boots u-boot in 4.3sec:
>> [snip]
>>> after, MPC8349ITX boots u-boot in 3.0sec:
>> Thanks for the good news! Memory POST test on my board with icach
>> disabled was lasting for hours until I enabled icach locally before
>> and disabled it after time consuming tests.
>>
>> BTW is there any reason that you enable icach in board specific rather
>> than in common code?
>
> not really, was just following the existing HID0-setting paradigm -
> I presume the paradigm came about to allow different cpu/board
> combinations to enable/disable different HID bits. Does that not sound
> valid to you?
Shouldn't you be using icache_enable(), or at least using HID0_INIT to
do invalidation and lock clearing?
-Scott
next prev parent reply other threads:[~2010-04-19 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 22:36 [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time Kim Phillips
2010-04-16 17:06 ` Michael Zaidman
2010-04-19 20:23 ` Kim Phillips
2010-04-19 20:19 ` Scott Wood [this message]
2010-04-19 22:34 ` Kim Phillips
2010-04-19 22:35 ` Scott Wood
2010-04-19 20:30 ` Timur Tabi
2010-04-19 20:41 ` Scott Wood
2010-04-19 21:05 ` Timur Tabi
2010-04-19 21:37 ` Kim Phillips
2010-04-20 1:39 ` Timur Tabi
2010-04-21 0:37 ` [U-Boot] [PATCH 3/3 v2] " Kim Phillips
2010-10-19 16:03 ` [U-Boot] ICACHE in core initialization to improve u-boot boot time: Breaks booting with i2c code while executing in flash Richard Retanubun
2010-10-20 19:50 ` Wolfgang Denk
2010-10-27 17:42 ` Richard Retanubun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCCBACC.6050801@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.