From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix Date: Mon, 19 Apr 2010 21:02:46 -0600 Message-ID: <4BCD1956.4040607@novell.com> References: <4BC8547A020000780003A98D@vpn.id2.novell.com> <4BC8CDCA.1000703@novell.com> <4BCC24A8020000780003AC70@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BCC24A8020000780003AC70@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: >>>> Jim Fehlig 16.04.10 22:51 >>> >>>> >> Jan Beulich wrote: >> >>> Perhaps this should even be further generalized (e.g. to remove any >>> "[!/]*:" pattern prefixes) to be more forward compatible? >>> >>> >> Right. Need to handle the 'ioemu' subtype as well. How about just >> stripping of everything before the leading '/'? E.g. like the attached >> patch? >> > > Wouldn't that become wrong when remote locations are acceptable > here (not sure if they aren't already), i.e. server:/path/file? IMO, remote locations should be handled by another tap driver optimized for the remote file protocol, similar to the nbd, curl, etc. block backends in qemu. > If that > is not expected to ever have a meaning and if relative paths aren't > permitted here, then yes, that would of course be the best solution. > The tools currently don't cope with relative paths in disk specification. Jim