From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O48xp-0004vw-7U for qemu-devel@nongnu.org; Tue, 20 Apr 2010 04:37:49 -0400 Received: from [140.186.70.92] (port=38072 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O48xk-0004tY-IM for qemu-devel@nongnu.org; Tue, 20 Apr 2010 04:37:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O48xj-0006iO-2J for qemu-devel@nongnu.org; Tue, 20 Apr 2010 04:37:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28268) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O48xi-0006iG-R8 for qemu-devel@nongnu.org; Tue, 20 Apr 2010 04:37:43 -0400 Message-ID: <4BCD67B2.4050807@redhat.com> Date: Tue, 20 Apr 2010 10:37:06 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] raw-posix: Use pread/pwrite instead of lseek+read/write References: <1271680452-24121-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1271680452-24121-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Jan Kiszka , qemu-devel@nongnu.org, Christoph Hellwig Am 19.04.2010 14:34, schrieb Stefan Hajnoczi: > This patch combines the lseek+read/write calls to use pread/pwrite > instead. This will result in fewer system calls and is already used by > AIO. > > Thanks to Jan Kiszka for identifying excessive > lseek and Christoph Hellwig for confirming that this > approach should work. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin