All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Gustavo Silva <silvagustavosilva@gmail.com>
Cc: "gregkh@suse.de" <gregkh@suse.de>,
	"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Gustavo Silva <silvagustavo@users.sourceforge.net>
Subject: Re: [PATCH] Staging: comedi: drivers: fix coding style issues in das08.c
Date: Tue, 20 Apr 2010 13:18:28 +0100	[thread overview]
Message-ID: <4BCD9B94.9090302@mev.co.uk> (raw)
In-Reply-To: <1271658070-10511-1-git-send-email-silvagustavo@users.sourceforge.net>

On 19/04/10 07:21, Gustavo Silva wrote:
> This is a patch to the das08.c file that fixes up the following issues
> found by the checkpatch.pl tool.

> -*/
>  /*
> -Driver: das08
> -Description: DAS-08 compatible boards
> -Author: Warren Jasper, ds, Frank Hess
> -Devices: [Keithley Metrabyte] DAS08 (isa-das08), [ComputerBoards] DAS08 (isa-das08),
> -  DAS08-PGM (das08-pgm),
> -  DAS08-PGH (das08-pgh), DAS08-PGL (das08-pgl), DAS08-AOH (das08-aoh),
> -  DAS08-AOL (das08-aol), DAS08-AOM (das08-aom), DAS08/JR-AO (das08/jr-ao),
> -  DAS08/JR-16-AO (das08jr-16-ao), PCI-DAS08 (das08),
> -  PC104-DAS08 (pc104-das08), DAS08/JR/16 (das08jr/16)
> -Status: works
> -
> -This is a rewrite of the das08 and das08jr drivers.
> -
> -Options (for ISA cards):
> -        [0] - base io address
> -
> -Options (for pci-das08):
> -        [0] - bus  (optional)
> -        [1] = slot (optional)
> -
> -The das08 driver doesn't support asynchronous commands, since
> -the cheap das08 hardware doesn't really support them.  The
> -comedi_rt_timer driver can be used to emulate commands for this
> -driver.
> -*/
> + * Driver: das08
> + * Description: DAS-08 compatible boards
> + * Author: Warren Jasper, ds, Frank Hess
> + * Devices: [Keithley Metrabyte] DAS08 (isa-das08),
> + * [ComputerBoards] DAS08 (isa-das08), DAS08-PGM (das08-pgm),
> + * DAS08-PGH (das08-pgh), DAS08-PGL (das08-pgl), DAS08-AOH (das08-aoh),
> + * DAS08-AOL (das08-aol), DAS08-AOM (das08-aom), DAS08/JR-AO (das08/jr-ao),
> + * DAS08/JR-16-AO (das08jr-16-ao), PCI-DAS08 (das08),
> + * PC104-DAS08 (pc104-das08), DAS08/JR/16 (das08jr/16)
> + * Status: works
> + *
> + * This is a rewrite of the das08 and das08jr drivers.
> + *
> + * Options (for ISA cards):
> + *             [0] - base io address
> + *
> + * Options (for pci-das08):
> + *             [0] - bus  (optional)
> + *             [1] = slot (optional)
> + *
> + * The das08 driver doesn't support asynchronous commands, since
> + * the cheap das08 hardware doesn't really support them.  The
> + * comedi_rt_timer driver can be used to emulate commands for this
> + * driver.
> + */

This part of the patch would screw up some scripts we have (in the CVS
version of comedi) for extracting driver documentation from the source code.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

  reply	other threads:[~2010-04-20 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19  6:21 [PATCH] Staging: comedi: drivers: fix coding style issues in das08.c Gustavo Silva
2010-04-20 12:18 ` Ian Abbott [this message]
2010-04-20 13:42   ` Greg KH
2010-04-20 15:03     ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCD9B94.9090302@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=silvagustavo@users.sourceforge.net \
    --cc=silvagustavosilva@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.