From: Jan Kiszka <jan.kiszka@web.de>
To: Amerigo Wang <xiyou.wangcong@gmail.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
Jeff Dike <jdike@addtoit.com>
Subject: Re: [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls
Date: Tue, 20 Apr 2010 19:14:43 +0200 [thread overview]
Message-ID: <4BCDE103.7080709@web.de> (raw)
In-Reply-To: <20100420101056.GC5317@cr0.nay.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
Amerigo Wang wrote:
> On Mon, Apr 19, 2010 at 11:53:07PM +0200, Jan Kiszka wrote:
>> The i386 subarch happens to pull in original NR_syscalls. Maybe we can
>> make that work for all host arch, but for now just avoid the clash by
>> using an all-upper-case name.
>>
>
> Where?
Not sure if this answers your question:
CC arch/um/kernel/skas/syscall.o
/data/linux-2.6/arch/um/kernel/skas/syscall.c:13:1: warning:
"NR_syscalls" redefined
In file included from /data/linux-2.6/arch/x86/include/asm/unistd.h:3,
from
/data/linux-2.6/arch/um/sys-i386/shared/sysdep/syscalls.h:6,
from /data/linux-2.6/arch/um/kernel/skas/syscall.c:10:
/data/linux-2.6/arch/x86/include/asm/unistd_32.h:349:1: warning: this is
the location of the previous definition
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2010-04-20 17:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 21:53 [PATCH 0/5] uml: Some trivial cleanups Jan Kiszka
2010-04-19 21:53 ` [PATCH 1/5] uml: Remove unused variable from line driver Jan Kiszka
2010-04-20 8:32 ` Amerigo Wang
2010-04-20 14:31 ` Jiri Kosina
2010-04-19 21:53 ` [uml-devel] [PATCH 2/5] uml: Drop private round_down definition Jan Kiszka
2010-04-19 21:53 ` Jan Kiszka
2010-04-20 8:33 ` Amerigo Wang
2010-04-20 14:25 ` Jeff Dike
2010-04-20 15:49 ` [uml-devel] " Jiri Kosina
2010-04-20 15:49 ` Jiri Kosina
2010-04-20 14:35 ` [uml-devel] " Jiri Kosina
2010-04-20 14:35 ` Jiri Kosina
2010-04-20 16:52 ` [uml-devel] " Jeff Dike
2010-04-20 17:18 ` Jiri Kosina
2010-04-20 17:18 ` Jiri Kosina
2010-04-19 21:53 ` [PATCH 3/5] uml: Fix warning due to missing task_struct declaration Jan Kiszka
2010-04-20 10:09 ` Amerigo Wang
2010-04-20 14:30 ` Jeff Dike
2010-04-20 17:09 ` [uml-devel] " Jan Kiszka
2010-04-20 17:09 ` Jan Kiszka
2010-04-20 23:43 ` Jiri Kosina
2010-04-21 6:06 ` [uml-devel] " Amerigo Wang
2010-04-21 6:06 ` Amerigo Wang
2010-04-21 9:38 ` [uml-devel] " Jiri Kosina
2010-04-21 9:38 ` Jiri Kosina
2010-04-21 10:43 ` [uml-devel] " Amerigo Wang
2010-04-21 10:43 ` Amerigo Wang
2010-04-21 10:49 ` Jiri Kosina
2010-04-19 21:53 ` [uml-devel] [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls Jan Kiszka
2010-04-19 21:53 ` Jan Kiszka
2010-04-20 10:10 ` Amerigo Wang
2010-04-20 17:14 ` Jan Kiszka [this message]
2010-04-21 6:12 ` Amerigo Wang
2010-05-10 21:38 ` Jiri Kosina
2010-04-19 21:53 ` [PATCH 5/5] uml: Clean up asm/system.h Jan Kiszka
2010-04-20 10:14 ` [uml-devel] " Amerigo Wang
2010-04-20 10:14 ` Amerigo Wang
2010-04-20 14:33 ` [uml-devel] " Jiri Kosina
2010-04-20 14:33 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCDE103.7080709@web.de \
--to=jan.kiszka@web.de \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.