From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Hugepages don't work on the Xen Linux git tree
Date: Tue, 20 Apr 2010 11:17:09 -0700
Message-ID: <4BCDEFA5.6000509@goop.org>
References: <201004192127.29270.dcm@mccr.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <201004192127.29270.dcm@mccr.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Dave McCracken <dcm@mccr.org>
Cc: Xen Developers List <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 04/19/2010 07:27 PM, Dave McCracken wrote:
> The fix I have in older kernels is for set_huge_pte_at() to call set_pmd() 
> instead.  However, in this brave new world of paravirt vectors, should I 
> instead set up a vector for it?  What is the architecturally right thing to 
> do?  However we decide to do it, expect a patch for it shortly afterward.
>   

Yeah, its a bit awkward.  A huge pte is semantically a pte, but
structurally a pmd, so which should it be?  The perhaps "cleanest" fix
might be to add a set of huge pte operators, but I don't think that's
really justified given that this is a fairly specific, narrow case.

I think on balance the best thing is to make set_huge_pte_at() call
set_pmd().

    J