All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Thomas Schwinge <thomas@schwinge.name>
Cc: Ian Campbell <ijc@hellion.org.uk>,
	xen-devel@lists.xensource.com,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: Debian linux-image-2.6.32-4-xen-amd64 2.6.32-11	doesn't boot with > 4 GiB; resets immediatelly, no log messages
Date: Tue, 20 Apr 2010 11:19:14 -0700	[thread overview]
Message-ID: <4BCDF022.5070304@goop.org> (raw)
In-Reply-To: <20100420111818.GA4416@kepler.schwinge.homeip.net>

On 04/20/2010 04:18 AM, Thomas Schwinge wrote:
> Hello!
>
> On Sat, Apr 10, 2010 at 03:52:45PM -0700, Jeremy Fitzhardinge wrote:
>   
>> On 04/10/2010 03:13 PM, Thomas Schwinge wrote:
>>     
>>>> Normally that would be OK, because it uses:
>>>>
>>>> 	__get_user(pfn, &machine_to_phys_mapping[mfn]);
>>>>
>>>> to dereference the array.  But at this early stage, none of the kernel's
>>>> exception handlers have been set up, so this will just fault into Xen.
>>>>
>>>> It would be interesting to confirm this by building your kernel with
>>>> CONFIG_DEBUG_INFO=y in the .config, and verify that the faulting
>>>> instruction is actually this line.
>>>>     
>>>>         
>>> Bingo!
>>>       
>> Excellent.  Now I just need to work out how to do a proper manual limit
>> check on the mfn.  (I've always been a bit suspicious of this code,
>> because there's no guarantee that a random invalid mfn *won't* happen to
>> return the pfn we're looking for...)
>>     
> Any news already about this one?
>
>   

Keir, is there a way to test the validity of an mfn before using it to
index into the m2p array?

    J

  reply	other threads:[~2010-04-20 18:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 11:34 Debian linux-image-2.6.32-4-xen-amd64 2.6.32-11 doesn't boot with > 4 GiB; resets immediatelly, no log messages Thomas Schwinge
2010-04-08 13:38 ` Konrad Rzeszutek Wilk
2010-04-08 13:42   ` Ian Campbell
2010-04-08 22:19   ` Thomas Schwinge
2010-04-08 22:51     ` Jeremy Fitzhardinge
2010-04-09 18:00       ` Thomas Schwinge
2010-04-09 18:20         ` Jeremy Fitzhardinge
2010-04-10 22:13           ` Thomas Schwinge
2010-04-10 22:52             ` Jeremy Fitzhardinge
2010-04-11  9:49               ` Thomas Goirand
2010-04-12 19:34                 ` Jeremy Fitzhardinge
2010-04-13  1:20                   ` Thomas Goirand
2010-04-13  6:02                     ` Pasi Kärkkäinen
2010-04-13  9:48                       ` Thomas Goirand
2010-04-13  9:52                         ` Pasi Kärkkäinen
2010-04-13 10:08                           ` Thomas Goirand
2010-04-13 19:50                     ` Jeremy Fitzhardinge
2010-04-13 22:27                       ` Thomas Goirand
2010-04-13 23:16                         ` Mike Viau
2010-04-13 23:59                         ` Jeremy Fitzhardinge
2010-04-14  5:48                           ` Thomas Goirand
2010-04-20 11:18               ` Thomas Schwinge
2010-04-20 18:19                 ` Jeremy Fitzhardinge [this message]
2010-04-28 21:21                 ` Jeremy Fitzhardinge
2010-05-08 15:46                   ` Thomas Schwinge
2010-05-08 23:01                     ` Jeremy Fitzhardinge
2010-05-10  9:48                       ` Thomas Schwinge
2010-04-09 18:52         ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCDF022.5070304@goop.org \
    --to=jeremy@goop.org \
    --cc=ijc@hellion.org.uk \
    --cc=keir.fraser@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=thomas@schwinge.name \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.