From: Rik van Riel <riel@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Pete Zaitcev <zaitcev@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rmap: anon_vma_prepare() can leak anon_vma_chain
Date: Tue, 20 Apr 2010 16:47:06 -0400 [thread overview]
Message-ID: <4BCE12CA.1070209@redhat.com> (raw)
In-Reply-To: <20100420192420.GA20840@redhat.com>
On 04/20/2010 03:24 PM, Oleg Nesterov wrote:
> If find_mergeable_anon_vma() succeeds but another thread installs
> ->anon_vma before we take ptl, then allocated == NULL but avc should
> be freed. Change the code to check avc != NULL to detect this case.
Good catch!
> Signed-off-by: Oleg Nesterov<oleg@redhat.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
prev parent reply other threads:[~2010-04-20 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100415120940.GA31762@redhat.com>
[not found] ` <4BCD0E78.9050904@redhat.com>
2010-04-20 19:24 ` [PATCH] rmap: anon_vma_prepare() can leak anon_vma_chain Oleg Nesterov
2010-04-20 20:47 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCE12CA.1070209@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.