From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: Lennert Buytenhek <buytenh@wantstofly.org>,
Andy Yan <ayan@marvell.com>, Ke Wei <kewei@marvell.com>,
Ying Chu <jasonchu@marvell.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue
Date: Tue, 20 Apr 2010 21:55:09 -0400 [thread overview]
Message-ID: <4BCE5AFD.4030108@garzik.org> (raw)
In-Reply-To: <4BCE43FD.1080303@gmail.com>
On 04/20/2010 08:17 PM, Robert Hancock wrote:
> On 04/20/2010 08:16 AM, Lennert Buytenhek wrote:
>> On mvsas, when I issue a SMART command (smartctl -a) while a dd
>> from /dev/sda to /dev/null is in progress, I hit the following
>> WARN_ON_ONCE in ata_qc_issue():
>>
>> if (ata_is_ncq(prot)) {
>> WARN_ON_ONCE(link->sactive& (1<< qc->tag));
>>
>> if (!link->sactive)
>> ap->nr_active_links++;
>> link->sactive |= 1<< qc->tag;
>> } else {
>> WARN_ON_ONCE(link->sactive); <===============
>>
>> ap->nr_active_links++;
>> link->active_tag = qc->tag;
>> }
>>
>> This is on 2.6.34-rc4 ish.
>
> That would indicate that for some reason, non-NCQ commands aren't being
> deferred while an NCQ command is in progress. Presumably something wrong
> in mvsas or libsas code in general..
Yep, definitely a problem in the mvsas (or libsas) area.
Jeff
prev parent reply other threads:[~2010-04-21 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 14:16 WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue Lennert Buytenhek
2010-04-21 0:17 ` Robert Hancock
2010-04-21 1:55 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCE5AFD.4030108@garzik.org \
--to=jeff@garzik.org \
--cc=ayan@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=hancockrwd@gmail.com \
--cc=jasonchu@marvell.com \
--cc=kewei@marvell.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.