Re: [PATCH] alsa-python: add register_poll to alsaseq

[Clemens Ladisch <clemens@ladisch.de>]

Hector Martin wrote:
> Attached patch adds register_poll to the sequencer bindings to support
> nonblocking sequencer access with the select module.
> 
> From db1a07ad9e9076f258d1ff871955eedc7d34ae9c Mon Sep 17 00:00:00 2001
> From: Hector Martin <hector@marcansoft.com>
> Date: Wed, 21 Apr 2010 05:54:49 +0200
> Subject: [PATCH] Add register_poll for alsaseq
> 
> ---
>  pyalsa/alsaseq.c |   53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 53 insertions(+), 0 deletions(-)

Please provide a Signed-off-by tag; we use this also for non-kernel code.

> +    pfd = malloc(sizeof(struct pollfd) * count);

This isn't freed; better use alloca().


Regards,
Clemens