From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: [PATCHv2 0/4] Add "xl info" command Date: Wed, 21 Apr 2010 15:56:58 +0100 Message-ID: <4BCF123A.3000509@eu.citrix.com> References: <1271859446-25892-1-git-send-email-andre.przywara@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1271859446-25892-1-git-send-email-andre.przywara@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andre Przywara Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 21/04/10 15:17, Andre Przywara wrote: > The "info" subcommand is missing from the xl tool. > The attached patchset adds support for this, extending libxl on the way > to provide the necessary info only by using own functions. > On my system the output of xm info and xl info was identical, I omitted > the recent NUMA additions from xl info for now and will provide the > necessary patches later. > > Reworked version due to comments from Ian and Vincent (thanks for the review!) > Changes to version 1: > - use Xen public headers for constants instead of (re-)defining them > - comment the meaning of the return value of get_sched_id() > - remove the masking feature for get_version_info > - make the version_info structure a member of libxl_ctx and fill it > on demand, omitting the need to free it manually all patches: Acked-by: Vincent Hanquez Thanks for your contribution ! -- Vincent