From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Wed, 21 Apr 2010 10:52:27 -0700
Subject: [U-Boot] [PATCH] smc911x driver frame alignment patch
In-Reply-To: <4BCEAFA6.8010605@niistt.ru>
References: <4BCEAFA6.8010605@niistt.ru>
Message-ID: <4BCF3B5B.60709@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Mike,

I know you use this driver a lot.  Please comment on this patch.

On 4/21/2010 12:56 AM, Valentin Yakovenkov wrote:
> Wrong alignment in smc911x driver when reading a frame from fifo.
> Neither smc911x chip nor U-Boot doesn't use IP-alignment, so we don't
> need to add anything here.
>
> Signed-off-by: Valentin Yakovenkov<yakovenkov@niistt.ru>
>
> diff -r 7dc8ff189175 a/drivers/net/smc911x.c
> --- a/drivers/net/smc911x.c	Mon Mar 29 11:08:55 2010 +0400
> +++ b/drivers/net/smc911x.c	Mon Apr 19 10:46:02 2010 +0400
> @@ -220,7 +220,7 @@
>
>   		smc911x_reg_write(dev, RX_CFG, 0);
>
> -		tmplen = (pktlen + 2+ 3) / 4;
> +		tmplen = (pktlen + 3) / 4;
>   		while (tmplen--)
>   			*data++ = pkt_data_pull(dev, RX_DATA_FIFO);
>
>
> --
>    WBR, Valentin
>    CJSC "NII STT", Russia, Smolensk
>    http://www.niistt.ru
>    

regards,
Ben