[Qemu-devel] Re: [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined)

[Stefan Weil <weil@mail.berlios.de>]

Stefan Weil schrieb:
> configure adds the macro WIN32_LEAN_AND_MEAN to
> QEMU_CFLAGS, and SDL_syswm.h defines it, too.
>
> This results in a compiler warning (redefinition of
> WIN32_LEAN_AND_MEAN in SDL_syswm.h. That warning prevents
> compilations for win32 with warning = error).
>
> Fix this by removing the definition of WIN32_LEAN_AND_MEAN
> before including SDL_syswm.h.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> sdl.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sdl.c b/sdl.c
> index 16a48e9..0334b4b 100644
> --- a/sdl.c
> +++ b/sdl.c
> @@ -21,6 +21,10 @@
> * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS IN
> * THE SOFTWARE.
> */
> +
> +/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
> +#undef WIN32_LEAN_AND_MEAN
> +
> #include <SDL.h>
> #include <SDL_syswm.h>
>

No comments, no questions? The original patch still applies.

It would be nice to have this patch in QEMU master.

Regards,
Stefan