From: Vipin KUMAR <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/17] SPEAr : i2c driver moved completely into drivers/i2c
Date: Thu, 22 Apr 2010 09:37:35 +0530 [thread overview]
Message-ID: <4BCFCB87.7070408@st.com> (raw)
In-Reply-To: <1271851882.22118.24.camel@ptyser-laptop>
On 4/21/2010 5:41 PM, Peter Tyser wrote:
> Hi Vipin,
>
> On Wed, 2010-04-21 at 13:24 +0530, Vipin KUMAR wrote:
>> The i2c IP used by spear platform is a synopsys i2c controller
>> The earlier driver adds the driver of this controller as if it is
>> specific to
>> spear platform.
>> The driver files are now moved into drivers/i2c folder for reusability
>> by other
>> platforms
>>
>> Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
>> ---
>> arch/arm/include/asm/arch-spear/spr_i2c.h | 146 -------------
>> drivers/i2c/Makefile | 2 +-
>> drivers/i2c/dw_i2c.c | 331
>> +++++++++++++++++++++++++++++
>
> I'd similarly lean towards naming the new file designware.c, or
> synopsis.c. It looks like the rest of the i2c drivers use a _i2c
> suffix, so I guess designware_i2c.c or synopsis_i2c.c would be best for
> consistency's sake. At a minimum it'd be nice to mention in the
> dw_i2c.c file what silicon the driver supports as right now a user needs
> to guess what "dw_i2c.c" runs on based solely on "dw".
>
OK, that's a good suggestion. I would change the name to
designware_i2c.c and also include a little description about the
manufacturer in the source header
> When you create patches with git format-patch, its nice to use the -M
> and -C to detect renames/copies. It makes the patch much smaller and
> much easier to review what actually changed.
>
OK, I would generate the patch v2 with these options enabled
Thanks for suggesting.
Please find the changes in next version patch-set
> Best,
> Peter
>
>
next prev parent reply other threads:[~2010-04-22 4:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 7:54 [U-Boot] [PATCH 00/17] Network support for spear platform and spear1300 support Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 01/17] u-boot.img file not created when srctree and objtree are different Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 02/17] change_bit routine defined Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 03/17] SPEAr : SMI erase and write timeouts increased Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 04/17] SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 05/17] SPEAr : Reducing the max RAM size to 128MB Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 06/17] SPEAr : Basic arch related support added for SPEAr SoCs Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 07/17] SPEAr : Network driver support added Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 08/17] SPEAr : Network support configured for spear SoCs Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 09/17] SPEAr : macb driver support added for spear310 and spear320 Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 10/17] SPEAr : FSMC driver support added Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 11/17] SPEAr : Configuring FSMC driver for NAND interface Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 12/17] SPEAr : i2c driver moved completely into drivers/i2c Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 13/17] SPEAr : smi driver moved completely into drivers/mtd Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 14/17] SPEAr : USBD driver support added Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 15/17] SPEAr : Basic spear1300 architecture " Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 16/17] SPEAr : spear1300 SoC " Vipin KUMAR
2010-04-21 7:54 ` [U-Boot] [PATCH 17/17] SPEAr : Supporting various configurations for spear3xx and spear6xx boards Vipin KUMAR
2010-04-21 12:11 ` [U-Boot] [PATCH 12/17] SPEAr : i2c driver moved completely into drivers/i2c Peter Tyser
2010-04-22 4:07 ` Vipin KUMAR [this message]
2010-04-21 17:02 ` [U-Boot] [PATCH 11/17] SPEAr : Configuring FSMC driver for NAND interface Scott Wood
2010-04-22 4:21 ` Vipin KUMAR
2010-04-22 15:39 ` Scott Wood
2010-04-21 17:02 ` [U-Boot] [PATCH 10/17] SPEAr : FSMC driver support added Scott Wood
2010-04-22 4:28 ` Vipin KUMAR
2010-04-22 16:01 ` Scott Wood
2010-04-21 12:00 ` [U-Boot] [PATCH 07/17] SPEAr : Network " Peter Tyser
2010-04-22 4:30 ` Vipin KUMAR
2010-04-21 17:48 ` Ben Warren
2010-04-22 4:43 ` Vipin KUMAR
2010-04-23 10:32 ` Armando VISCONTI
2010-04-26 5:02 ` Ben Warren
2010-04-26 8:01 ` Armando VISCONTI
2010-04-26 8:34 ` Vipin KUMAR
2010-04-21 11:51 ` [U-Boot] [PATCH 06/17] SPEAr : Basic arch related support added for SPEAr SoCs Peter Tyser
2010-04-22 4:45 ` Vipin KUMAR
2010-04-21 11:54 ` [U-Boot] [PATCH 00/17] Network support for spear platform and spear1300 support Peter Tyser
2010-04-21 12:00 ` Vipin KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCFCB87.7070408@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.