From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCHv2 1/4] libxl: extend physinfo structure
Date: Thu, 22 Apr 2010 10:03:18 +0200
Message-ID: <4BD002C6.5040701@redhat.com>
References: <1271859446-25892-1-git-send-email-andre.przywara@amd.com>
	<1271859446-25892-2-git-send-email-andre.przywara@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1271859446-25892-2-git-send-email-andre.przywara@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Andre Przywara <andre.przywara@amd.com>
Cc: vincent.hanquez@eu.citrix.com, xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com, Keir.Fraser@eu.citrix.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/21/2010 04:17 PM, Andre Przywara wrote:
> The libxl version of the physinfo sysctl does not contain some
> fields like nr_nodes or capabilities needed for xl info output.
> Add them to the structure and the retrieving function.

Vincent, Stefano, is it okay to break the ABI?

If so, I suggest adding an initial member to be filled with sizeof() of 
the structure, similar to many Win32 APIs like GetVersionEx.

http://msdn.microsoft.com/en-us/library/ms724451%28VS.85%29.aspx
http://msdn.microsoft.com/en-us/library/ms724834%28VS.85%29.aspx
http://msdn.microsoft.com/en-us/library/ms724833%28VS.85%29.aspx

Paolo