From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O4stI-00046z-Qo
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 05:40:12 -0400
Received: from [140.186.70.92] (port=58301 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O4stG-000463-GX
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 05:40:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mjt@tls.msk.ru>) id 1O4stE-0006Ag-QC
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 05:40:10 -0400
Received: from isrv.corpit.ru ([81.13.33.159]:34801)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mjt@tls.msk.ru>) id 1O4stE-0006A9-GU
	for qemu-devel@nongnu.org; Thu, 22 Apr 2010 05:40:08 -0400
Message-ID: <4BD01972.9030006@msgid.tls.msk.ru>
Date: Thu, 22 Apr 2010 13:40:02 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial
	number
References: <20100311.234200.145758949990685830.kou1.ono@gmail.com>
	<4B990D78.6050708@msgid.tls.msk.ru>
In-Reply-To: <4B990D78.6050708@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>

11.03.2010 18:34, Michael Tokarev wrote:
[]
>> On version 0.12.3, -drive serial=XXX option does not work.
>> Below patch fixes it. 'serial' is pointer, not array.
>>
>>
>> --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
>> +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
>> @@ -2397,7 +2397,7 @@
>>       dinfo->on_write_error = on_write_error;
>>       dinfo->opts = opts;
>>       if (serial)
>> -        strncpy(dinfo->serial, serial, sizeof(serial));
>> +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
>>       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
>>       if (is_extboot) {
>>           extboot_drive = dinfo;

Folks, can we please add this trivial one-liner to -stable or something?
It has been one and a half months since it has been fixed in debian...

Thanks!

/mjt